danvics/ytdl-sub
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[BUGFIX] Embedded null byte ffmpeg fix (#1363)

Browse source 
Closes https://github.com/jmbannon/ytdl-sub/issues/710

Fixes the notorious embedded null byte error seen during FFMPEG metadata writes when handling special characters.
This commit is contained in:
Jesse Bannon 2025-10-16 08:01:37 -07:00 committed by GitHub
parent 1b2e34bad4
commit 7364aac00c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/ytdl_sub/utils/ffmpeg.py
View file

@ -201,7 +201,11 @@ def add_ffmpeg_metadata_key_values(file_path: str, key_values: Dict[str, str]) -
"-dn", # ignore data streams
]
for key, value in key_values.items():
ffmpeg_args.extend(["-metadata", f"{key}={value}"])
# Some special characters (utf-16 maybe?) have null-byte
# which results in ffmpeg error, remove them outright
value_null_byte_removed = value.replace("\0", "")
ffmpeg_args.extend(["-metadata", f"{key}={value_null_byte_removed}"])
ffmpeg_args.extend(["-codec", "copy", "-bitexact", tmp_file_path])
FFMPEG.run(ffmpeg_args)