danvics/ytdl-sub
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

bitexact on video tags

Browse source
This commit is contained in:
Jesse Bannon 2023-10-27 22:52:45 -07:00
parent f4e478ca3d
commit 733b281b03
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/ytdl_sub/utils/ffmpeg.py
View file

@ -202,7 +202,7 @@ def add_ffmpeg_metadata_key_values(file_path: str, key_values: Dict[str, str]) -
]
for key, value in key_values.items():
ffmpeg_args.extend(["-metadata", f"{key}={value}"])
ffmpeg_args.extend(["-codec", "copy", tmp_file_path])
ffmpeg_args.extend(["-codec", "copy", "-bitexact", tmp_file_path])
FFMPEG.run(ffmpeg_args)
FileHandler.move(tmp_file_path, file_path)

2
tests/e2e/plugins/test_file_convert.py
View file

@ -12,7 +12,7 @@ def preset_dict(output_directory):
"preset": "Jellyfin Music Videos",
"download": "https://www.youtube.com/watch?v=2zYF9JLHDmA",
"output_options": {"output_directory": output_directory},
"format": "worst[ext=mp4]", # download the worst format so it is fast
"format": "best[ext=mp4]", # download the worst format so it is fast
"ytdl_options": {
"postprocessor_args": {"ffmpeg": ["-bitexact"]}, # Must add this for reproducibility
},

2
tests/resources/expected_downloads_summaries/plugins/file_convert/output.json
View file

@ -1,6 +1,6 @@
{
".ytdl-sub-file_convert_test-download-archive.json": "f720289a704349fbe38ef5ed451af724",
"file_convert_test/When you hear Hugh Jackman is returning as Wolverine in Deadpool 3.jpg": "662fcaadf6e80d63591bac19a5fdffb0",
"file_convert_test/When you hear Hugh Jackman is returning as Wolverine in Deadpool 3.mp4": "21d860268f6a27f4ec65d8278ee7b229",
"file_convert_test/When you hear Hugh Jackman is returning as Wolverine in Deadpool 3.mp4": "14ebeb4b5d4e283701530e61c741598b",
"file_convert_test/When you hear Hugh Jackman is returning as Wolverine in Deadpool 3.nfo": "752e6b6eea853c8a1f62faa4b841b292"
}

2
tests/resources/expected_downloads_summaries/plugins/file_convert/output_custom_ffmpeg.json
View file

@ -1,6 +1,6 @@
{
".ytdl-sub-file_convert_test-download-archive.json": "8fa4bf42c9686f8520ce107e48b73215",
"file_convert_test/When you hear Hugh Jackman is returning as Wolverine in Deadpool 3.jpg": "662fcaadf6e80d63591bac19a5fdffb0",
"file_convert_test/When you hear Hugh Jackman is returning as Wolverine in Deadpool 3.mkv": "c354b9d9f542bc1762b7103adbf56ee6",
"file_convert_test/When you hear Hugh Jackman is returning as Wolverine in Deadpool 3.mkv": "5a59b7454a7d7a07ef27fec438ba8e21",
"file_convert_test/When you hear Hugh Jackman is returning as Wolverine in Deadpool 3.nfo": "752e6b6eea853c8a1f62faa4b841b292"
}