danvics/ytdl-sub
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix unit test

Browse source
This commit is contained in:
Jesse Bannon 2023-02-20 14:10:34 -08:00
parent 39b6d7705f
commit 6f662eedea
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/ytdl_sub/main.py
View file

@ -32,11 +32,11 @@ def main():
sys.exit(1) sys.exit(1)
except Exception: # pylint: disable=broad-except except Exception: # pylint: disable=broad-except
logger.exception("An uncaught error occurred:") logger.exception("An uncaught error occurred:")
logger.error("Version: %s", __version__)
logger.error( logger.error(
"Please upload the error log file '%s' and make a Github " "Version %s\nPlease upload the error log file '%s' and make a Github "
"issue at https://github.com/jmbannon/ytdl-sub/issues with your config and " "issue at https://github.com/jmbannon/ytdl-sub/issues with your config and "
"command/subscription yaml file to reproduce. Thanks for trying ytdl-sub!", "command/subscription yaml file to reproduce. Thanks for trying ytdl-sub!",
__version__,
Logger.debug_log_filename(), Logger.debug_log_filename(),
) )
sys.exit(1) sys.exit(1)

6
tests/unit/main/test_main.py
View file

@ -5,6 +5,7 @@ from unittest.mock import patch
import pytest import pytest
from src.ytdl_sub import __version__
from src.ytdl_sub.main import main from src.ytdl_sub.main import main
from ytdl_sub.utils.exceptions import ValidationException from ytdl_sub.utils.exceptions import ValidationException
from ytdl_sub.utils.logger import Logger from ytdl_sub.utils.logger import Logger
@ -13,7 +14,7 @@ from ytdl_sub.utils.logger import Logger
@pytest.fixture @pytest.fixture
def expected_uncaught_error_message(): def expected_uncaught_error_message():
return ( return (
f"Please upload the error log file '%s' and make a " f"Version %s\nPlease upload the error log file '%s' and make a "
f"Github issue at https://github.com/jmbannon/ytdl-sub/issues with your config and " f"Github issue at https://github.com/jmbannon/ytdl-sub/issues with your config and "
f"command/subscription yaml file to reproduce. Thanks for trying ytdl-sub!" f"command/subscription yaml file to reproduce. Thanks for trying ytdl-sub!"
) )
@ -63,4 +64,5 @@ def test_main_uncaught_error(capsys, mock_sys_exit, expected_uncaught_error_mess
assert mock_error.call_count == 1 assert mock_error.call_count == 1
assert mock_error.call_args.args[0] == expected_uncaught_error_message assert mock_error.call_args.args[0] == expected_uncaught_error_message
assert mock_error.call_args.args[1] == Logger.debug_log_filename() assert mock_error.call_args.args[1] == __version__
assert mock_error.call_args.args[2] == Logger.debug_log_filename()