From 6b6031b77e037adefdc755fb7901998828f657cf Mon Sep 17 00:00:00 2001
From: Jesse Bannon <jbann1994@gmail.com>
Date: Mon, 29 Dec 2025 23:11:22 -0800
Subject: [PATCH] perhaps fixedd

---
 .../config/validators/variable_validation.py  |  2 +-
 .../validators/string_formatter_validators.py | 14 +++++++---
 tests/unit/config/test_preset.py              | 24 -----------------
 .../config/test_subscription_validation.py    | 27 +++++++++++++++++++
 4 files changed, 38 insertions(+), 29 deletions(-)

diff --git a/src/ytdl_sub/config/validators/variable_validation.py b/src/ytdl_sub/config/validators/variable_validation.py
index 6d738ceb..ac8c7504 100644
--- a/src/ytdl_sub/config/validators/variable_validation.py
+++ b/src/ytdl_sub/config/validators/variable_validation.py
@@ -50,7 +50,7 @@ def _add_dummy_overrides(overrides: Overrides) -> Dict[str, str]:
         try:
             # Attempt to get the resolved version, which will only happen
             # if it does not have any dependencies to the entry
-            value = ScriptUtils.to_script(overrides.script.get(override_name).native)
+            value = f'{{%string("""{overrides.script.get(override_name).native}""")}}'
         except RuntimeException:
             value = to_variable_dependency_format_string(
                 script=overrides.script,
diff --git a/src/ytdl_sub/validators/string_formatter_validators.py b/src/ytdl_sub/validators/string_formatter_validators.py
index 83e47479..1ac309a3 100644
--- a/src/ytdl_sub/validators/string_formatter_validators.py
+++ b/src/ytdl_sub/validators/string_formatter_validators.py
@@ -52,7 +52,10 @@ class StringFormatterValidator(StringValidator):
     def __init__(self, name, value: str):
         super().__init__(name=name, value=value)
         try:
-            _ = parse(str(value))
+            self._parsed = parse(
+                text=str(value),
+                name=self.leaf_name,
+            )
         except UserException as exc:
             raise self._validation_exception(exc) from exc
 
@@ -66,6 +69,11 @@ class StringFormatterValidator(StringValidator):
         """
         return self._value
 
+    @property
+    @final
+    def parsed(self) -> SyntaxTree:
+        return self._parsed
+
     def post_process(self, resolved: str) -> str:
         """
         Returns
@@ -218,9 +226,7 @@ def _validate_formatter(
         is_static_formatter = True
         unresolvable = unresolved_variables.union({VARIABLES.entry_metadata.variable_name})
 
-    parsed = parse(
-        text=formatter_validator.format_string,
-    )
+    parsed = formatter_validator.parsed
     variable_names = {var.name for var in parsed.variables}
     custom_function_names = {f"%{func.name}" for func in parsed.custom_functions}
 
diff --git a/tests/unit/config/test_preset.py b/tests/unit/config/test_preset.py
index 6e9eaf56..cd4f2b17 100644
--- a/tests/unit/config/test_preset.py
+++ b/tests/unit/config/test_preset.py
@@ -340,27 +340,3 @@ class TestPreset:
                     "output_options": {"output_directory": "dir", "file_name": "acjk"},
                 },
             )
-
-    def test_preset_error_override_name_conflicts_with_plugin(self, config_file, output_options):
-        with pytest.raises(
-            ValidationException,
-            match=re.escape(
-                "Override variable with name throttle_protection cannot be used since it is the "
-                "name of a plugin. Perhaps you meant to define it as a plugin? If so, indent it "
-                "left to make it at the same level as overrides."
-            ),
-        ):
-            _ = Preset(
-                config=config_file,
-                name="test",
-                value={
-                    "download": {
-                        "url": "youtube.com/watch?v=123abc",
-                    },
-                    "subtitles": {
-                        "embed_subtitles": True,
-                    },
-                    "output_options": {"output_directory": "dir", "file_name": "acjk"},
-                    "overrides": {"throttle_protection": "nope"},
-                },
-            )
diff --git a/tests/unit/config/test_subscription_validation.py b/tests/unit/config/test_subscription_validation.py
index 7a8e8ff2..3a6fd13d 100644
--- a/tests/unit/config/test_subscription_validation.py
+++ b/tests/unit/config/test_subscription_validation.py
@@ -143,3 +143,30 @@ class TestSubscriptionValidation:
                 ),
                 config=config_file,
             )
+
+    def test_preset_error_override_name_conflicts_with_plugin(self, config_file, output_options):
+        with pytest.raises(
+            ValidationException,
+            match=re.escape(
+                "Override variable with name throttle_protection cannot be used since it is the "
+                "name of a plugin. Perhaps you meant to define it as a plugin? If so, indent it "
+                "left to make it at the same level as overrides."
+            ),
+        ):
+            _ = Subscription.from_preset(
+                preset=Preset(
+                    config=config_file,
+                    name="test",
+                    value={
+                        "download": {
+                            "url": "youtube.com/watch?v=123abc",
+                        },
+                        "subtitles": {
+                            "embed_subtitles": True,
+                        },
+                        "output_options": {"output_directory": "dir", "file_name": "acjk"},
+                        "overrides": {"throttle_protection": "nope"},
+                    },
+                ),
+                config=config_file,
+            )