From 5d40d02eb373053046347d7da1617042ee5d8eb1 Mon Sep 17 00:00:00 2001 From: Jesse Bannon Date: Thu, 2 Mar 2023 13:01:01 -0800 Subject: [PATCH] [BACKEND] Make break message debug level and more clear (#496) --- src/ytdl_sub/downloaders/downloader.py | 10 +++++----- tests/e2e/plugins/test_date_range.py | 8 ++++---- tests/e2e/youtube/test_playlist.py | 4 ++-- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/ytdl_sub/downloaders/downloader.py b/src/ytdl_sub/downloaders/downloader.py index 5d55c66f..4d6d3dab 100644 --- a/src/ytdl_sub/downloaders/downloader.py +++ b/src/ytdl_sub/downloaders/downloader.py @@ -369,14 +369,14 @@ class Downloader(DownloadArchiver, Generic[DownloaderOptionsT], ABC): with self._listen_and_log_downloaded_info_json(log_prefix=log_prefix_on_info_json_dl): _ = self.extract_info(ytdl_options_overrides=ytdl_options_overrides, **kwargs) except RejectedVideoReached: - download_logger.info( - "RejectedVideoReached, stopping additional downloads. " - "Disable by setting `ytdl_options.break_on_reject` to False." + download_logger.debug( + "RejectedVideoReached, stopping additional downloads " + "(Can be disable by setting `ytdl_options.break_on_reject` to False)." ) except ExistingVideoReached: - download_logger.info( + download_logger.debug( "ExistingVideoReached, stopping additional downloads. " - "Disable by setting `ytdl_options.break_on_existing` to False." + "(Can be disable by setting `ytdl_options.break_on_existing` to False)." ) except MaxDownloadsReached: download_logger.info("MaxDownloadsReached, stopping additional downloads.") diff --git a/tests/e2e/plugins/test_date_range.py b/tests/e2e/plugins/test_date_range.py index db77410e..a2a5de42 100644 --- a/tests/e2e/plugins/test_date_range.py +++ b/tests/e2e/plugins/test_date_range.py @@ -70,7 +70,7 @@ class TestDateRange: with assert_logs( logger=ytdl_sub.downloaders.downloader.download_logger, expected_message="ExistingVideoReached, stopping additional downloads", - log_level="info", + log_level="debug", ): transaction_log = recent_channel_subscription.download() assert_transaction_log_matches( @@ -141,7 +141,7 @@ class TestDateRange: with assert_logs( logger=ytdl_sub.downloaders.downloader.download_logger, expected_message="RejectedVideoReached, stopping additional downloads", - log_level="info", + log_level="debug", ): transaction_log = recent_channel_subscription.download(dry_run=False) @@ -161,7 +161,7 @@ class TestDateRange: with assert_logs( logger=ytdl_sub.downloaders.downloader.download_logger, expected_message="ExistingVideoReached, stopping additional downloads", - log_level="info", + log_level="debug", ): transaction_log = rolling_recent_channel_subscription.download(dry_run=dry_run) @@ -188,7 +188,7 @@ class TestDateRange: with assert_logs( logger=ytdl_sub.downloaders.downloader.download_logger, expected_message="ExistingVideoReached, stopping additional downloads", - log_level="info", + log_level="debug", ): transaction_log = rolling_recent_channel_subscription.download() diff --git a/tests/e2e/youtube/test_playlist.py b/tests/e2e/youtube/test_playlist.py index d0f15b66..ac81a38e 100644 --- a/tests/e2e/youtube/test_playlist.py +++ b/tests/e2e/youtube/test_playlist.py @@ -85,7 +85,7 @@ class TestPlaylist: with assert_logs( logger=ytdl_sub.downloaders.downloader.download_logger, expected_message="ExistingVideoReached, stopping additional downloads", - log_level="info", + log_level="debug", ): _ = playlist_subscription.download() @@ -133,7 +133,7 @@ class TestPlaylist: with assert_logs( logger=ytdl_sub.downloaders.downloader.download_logger, expected_message="ExistingVideoReached, stopping additional downloads", - log_level="info", + log_level="debug", ): _ = mock_run_from_cli(args=args)[0][1]