danvics/ytdl-sub
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

better messages

Browse source
This commit is contained in:
Jesse Bannon 2025-06-06 10:05:39 -07:00
parent 23a0b3d434
commit 577afba4ce
3 changed files with 22 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/ytdl_sub/downloaders/ytdlp.py
View file

@ -17,7 +17,7 @@ from yt_dlp.utils import RejectedVideoReached
from ytdl_sub.thread.log_entries_downloaded_listener import LogEntriesDownloadedListener from ytdl_sub.thread.log_entries_downloaded_listener import LogEntriesDownloadedListener
from ytdl_sub.utils.exceptions import FileNotDownloadedException from ytdl_sub.utils.exceptions import FileNotDownloadedException
from ytdl_sub.utils.logger import Logger from ytdl_sub.utils.logger import Logger, LoggerLevels
class YTDLP: class YTDLP:
@ -123,10 +123,17 @@ class YTDLP:
del copied_ytdl_options_overrides["download_archive"] del copied_ytdl_options_overrides["download_archive"]
if num_tries < cls._EXTRACT_ENTRY_NUM_RETRIES: if num_tries < cls._EXTRACT_ENTRY_NUM_RETRIES:
maybe_inform_verbose = ""
if Logger.get_log_level().level < LoggerLevels.VERBOSE.level:
maybe_inform_verbose = (
". Consider inspecting the yt-dlp logs using `--log-level verbose` to "
"see the issue."
)
cls.logger.info( cls.logger.info(
"Failed to download entry. Retrying %d / %d", "Failed to download entry. Retrying %d / %d%s",
num_tries, num_tries,
cls._EXTRACT_ENTRY_NUM_RETRIES, cls._EXTRACT_ENTRY_NUM_RETRIES,
maybe_inform_verbose
) )
# Still return if the media file downloaded (thumbnail could be missing) # Still return if the media file downloaded (thumbnail could be missing)
@ -223,17 +230,13 @@ class YTDLP:
cls.extract_info(ytdl_options_overrides=ytdl_options_overrides, **kwargs) cls.extract_info(ytdl_options_overrides=ytdl_options_overrides, **kwargs)
except RejectedVideoReached: except RejectedVideoReached:
cls.logger.info( cls.logger.info(
"RejectedVideoReached, stopping additional downloads " "RejectedVideoReached, stopping additional downloads. "
"(Can be disable by setting `date_range.breaks` to False. " "Can be disable by setting `date_range.breaks` to False."
"If this is unexpected, "
"run with `--log-level verbose` to see the yt-dlp logs on why it stopped)"
) )
except ExistingVideoReached: except ExistingVideoReached:
cls.logger.info( cls.logger.info(
"ExistingVideoReached, stopping additional downloads. " "ExistingVideoReached, stopping additional downloads. "
"(Can be disable by setting `ytdl_options.break_on_existing` to False. This will " "Can be disable by setting `ytdl_options.break_on_existing` to False."
"force yt-dlp to continue scraping all metadata to grab any files you may have "
"missed)"
) )
except MaxDownloadsReached: except MaxDownloadsReached:
cls.logger.info("MaxDownloadsReached, stopping additional downloads.") cls.logger.info("MaxDownloadsReached, stopping additional downloads.")

2
src/ytdl_sub/plugins/subtitles.py
View file

@ -198,7 +198,7 @@ class SubtitlesPlugin(Plugin[SubtitleOptions]):
""" """
requested_subtitles = entry.get(v.requested_subtitles, expected_type=dict) requested_subtitles = entry.get(v.requested_subtitles, expected_type=dict)
if not requested_subtitles: if not requested_subtitles:
logger.info("subtitles not found for %s", entry.title) logger.info("Subtitles not found for %s", entry.title)
return None return None
file_metadata: Optional[FileMetadata] = None file_metadata: Optional[FileMetadata] = None

9
src/ytdl_sub/utils/logger.py
View file

@ -125,6 +125,15 @@ class Logger:
""" """
cls._LOGGER_LEVEL = LoggerLevels.from_str(name=log_level_name) cls._LOGGER_LEVEL = LoggerLevels.from_str(name=log_level_name)
@classmethod
def get_log_level(cls) -> LoggerLevel:
"""
Returns
-------
Application's log level
"""
return cls._LOGGER_LEVEL
@classmethod @classmethod
def _get_formatter(cls) -> logging.Formatter: def _get_formatter(cls) -> logging.Formatter:
""" """