From b195f374125a6ab64e57ad9dbed7ef2ba4ab8577 Mon Sep 17 00:00:00 2001 From: Jesse Bannon Date: Sun, 10 May 2026 08:59:32 -0700 Subject: [PATCH] [DEV] Disable soundcloud e2e test in CI (#1448) --- tests/e2e/cli/test_view.py | 4 ++-- tests/e2e/plugins/test_audio_extract.py | 4 ++-- tests/e2e/plugins/test_chapters.py | 4 ++-- tests/e2e/plugins/test_date_range.py | 4 ++-- tests/e2e/plugins/test_file_convert.py | 4 ++-- tests/e2e/plugins/test_match_filters.py | 4 ++-- tests/e2e/plugins/test_split_by_chapters.py | 4 ++-- tests/e2e/plugins/test_subtitles.py | 4 ++-- tests/e2e/presets/test_bilateral.py | 4 ++-- tests/e2e/presets/test_soundcloud.py | 2 ++ tests/e2e/youtube/test_channel.py | 4 ++-- tests/e2e/youtube/test_video.py | 4 ++-- tests/resources.py | 2 +- 13 files changed, 25 insertions(+), 23 deletions(-) diff --git a/tests/e2e/cli/test_view.py b/tests/e2e/cli/test_view.py index b918cbfb..21c38f44 100644 --- a/tests/e2e/cli/test_view.py +++ b/tests/e2e/cli/test_view.py @@ -2,12 +2,12 @@ from typing import Optional import pytest from conftest import mock_run_from_cli -from resources import DISABLE_YOUTUBE_TESTS +from resources import DISABLE_E2E_TESTS from ytdl_sub.utils.file_handler import FileMetadata -@pytest.mark.skipif(DISABLE_YOUTUBE_TESTS, reason="YouTube tests cannot run in GH") +@pytest.mark.skipif(DISABLE_E2E_TESTS, reason="YouTube tests cannot run in GH") class TestView: @pytest.mark.parametrize("split_chapters", [True, False]) def test_view_from_cli( diff --git a/tests/e2e/plugins/test_audio_extract.py b/tests/e2e/plugins/test_audio_extract.py index 347dead7..4ca3f32e 100644 --- a/tests/e2e/plugins/test_audio_extract.py +++ b/tests/e2e/plugins/test_audio_extract.py @@ -1,7 +1,7 @@ import pytest from expected_download import assert_expected_downloads from expected_transaction_log import assert_transaction_log_matches -from resources import DISABLE_YOUTUBE_TESTS +from resources import DISABLE_E2E_TESTS from ytdl_sub.subscriptions.subscription import Subscription @@ -47,7 +47,7 @@ def youtube_release_preset_dict(output_directory): } -@pytest.mark.skipif(DISABLE_YOUTUBE_TESTS, reason="YouTube tests cannot run in GH") +@pytest.mark.skipif(DISABLE_E2E_TESTS, reason="YouTube tests cannot run in GH") class TestAudioExtract: @pytest.mark.parametrize("dry_run", [False]) def test_audio_extract_single_song( diff --git a/tests/e2e/plugins/test_chapters.py b/tests/e2e/plugins/test_chapters.py index 7604a162..39a7cfd1 100644 --- a/tests/e2e/plugins/test_chapters.py +++ b/tests/e2e/plugins/test_chapters.py @@ -3,7 +3,7 @@ from typing import Dict import pytest from expected_download import assert_expected_downloads from expected_transaction_log import assert_transaction_log_matches -from resources import DISABLE_YOUTUBE_TESTS +from resources import DISABLE_E2E_TESTS from ytdl_sub.subscriptions.subscription import Subscription @@ -54,7 +54,7 @@ def chapters_from_comments_preset_dict(sponsorblock_and_subs_preset_dict: Dict) return sponsorblock_and_subs_preset_dict -@pytest.mark.skipif(DISABLE_YOUTUBE_TESTS, reason="YouTube tests cannot run in GH") +@pytest.mark.skipif(DISABLE_E2E_TESTS, reason="YouTube tests cannot run in GH") class TestChapters: @pytest.mark.parametrize("dry_run", [True, False]) def test_chapters_sponsorblock_and_removal_with_subs( diff --git a/tests/e2e/plugins/test_date_range.py b/tests/e2e/plugins/test_date_range.py index a4ec0f41..675492b4 100644 --- a/tests/e2e/plugins/test_date_range.py +++ b/tests/e2e/plugins/test_date_range.py @@ -5,7 +5,7 @@ import pytest from conftest import assert_logs from expected_download import assert_expected_downloads from expected_transaction_log import assert_transaction_log_matches -from resources import DISABLE_YOUTUBE_TESTS +from resources import DISABLE_E2E_TESTS from ytdl_sub.downloaders.ytdlp import YTDLP from ytdl_sub.subscriptions.subscription import Subscription @@ -39,7 +39,7 @@ def rolling_recent_channel_preset_dict(recent_preset_dict): ) -@pytest.mark.skipif(DISABLE_YOUTUBE_TESTS, reason="YouTube tests cannot run in GH") +@pytest.mark.skipif(DISABLE_E2E_TESTS, reason="YouTube tests cannot run in GH") class TestDateRange: @pytest.mark.parametrize("dry_run", [True, False]) @pytest.mark.parametrize("date_range_breaks", [True, False]) diff --git a/tests/e2e/plugins/test_file_convert.py b/tests/e2e/plugins/test_file_convert.py index 6a9013db..d9506b57 100644 --- a/tests/e2e/plugins/test_file_convert.py +++ b/tests/e2e/plugins/test_file_convert.py @@ -1,7 +1,7 @@ import pytest from expected_download import assert_expected_downloads from expected_transaction_log import assert_transaction_log_matches -from resources import DISABLE_YOUTUBE_TESTS +from resources import DISABLE_E2E_TESTS from ytdl_sub.subscriptions.subscription import Subscription @@ -20,7 +20,7 @@ def preset_dict(output_directory): } -@pytest.mark.skipif(DISABLE_YOUTUBE_TESTS, reason="YouTube tests cannot run in GH") +@pytest.mark.skipif(DISABLE_E2E_TESTS, reason="YouTube tests cannot run in GH") class TestFileConvert: @pytest.mark.parametrize("dry_run", [True, False]) def test_file_convert( diff --git a/tests/e2e/plugins/test_match_filters.py b/tests/e2e/plugins/test_match_filters.py index 6a65ee9b..e7734afa 100644 --- a/tests/e2e/plugins/test_match_filters.py +++ b/tests/e2e/plugins/test_match_filters.py @@ -1,7 +1,7 @@ import pytest from expected_download import assert_expected_downloads from expected_transaction_log import assert_transaction_log_matches -from resources import DISABLE_YOUTUBE_TESTS +from resources import DISABLE_E2E_TESTS from ytdl_sub.subscriptions.subscription import Subscription @@ -46,7 +46,7 @@ def livestream_preset_dict(output_directory): } -@pytest.mark.skipif(DISABLE_YOUTUBE_TESTS, reason="YouTube tests cannot run in GH") +@pytest.mark.skipif(DISABLE_E2E_TESTS, reason="YouTube tests cannot run in GH") class TestFileConvert: def test_livestreams_download_filtered( self, diff --git a/tests/e2e/plugins/test_split_by_chapters.py b/tests/e2e/plugins/test_split_by_chapters.py index ffffb7b4..bd9f186b 100644 --- a/tests/e2e/plugins/test_split_by_chapters.py +++ b/tests/e2e/plugins/test_split_by_chapters.py @@ -4,7 +4,7 @@ import mergedeep import pytest from expected_download import assert_expected_downloads from expected_transaction_log import assert_transaction_log_matches -from resources import DISABLE_YOUTUBE_TESTS +from resources import DISABLE_E2E_TESTS from ytdl_sub.subscriptions.subscription import Subscription from ytdl_sub.utils.exceptions import ValidationException @@ -58,7 +58,7 @@ def yt_album_as_chapters_with_regex_preset_dict(yt_album_as_chapters_preset_dict return yt_album_as_chapters_preset_dict -@pytest.mark.skipif(DISABLE_YOUTUBE_TESTS, reason="YouTube tests cannot run in GH") +@pytest.mark.skipif(DISABLE_E2E_TESTS, reason="YouTube tests cannot run in GH") class TestSplitByChapters: @pytest.mark.parametrize("dry_run", [True, False]) def test_video_with_chapters( diff --git a/tests/e2e/plugins/test_subtitles.py b/tests/e2e/plugins/test_subtitles.py index 110d374c..833e7109 100644 --- a/tests/e2e/plugins/test_subtitles.py +++ b/tests/e2e/plugins/test_subtitles.py @@ -1,7 +1,7 @@ import pytest from expected_download import assert_expected_downloads from expected_transaction_log import assert_transaction_log_matches -from resources import DISABLE_YOUTUBE_TESTS +from resources import DISABLE_E2E_TESTS from ytdl_sub.config.config_file import ConfigFile from ytdl_sub.subscriptions.subscription import Subscription @@ -32,7 +32,7 @@ def test_single_video_subs_embed_and_file_preset_dict(single_video_subs_embed_pr return single_video_subs_embed_preset_dict -@pytest.mark.skipif(DISABLE_YOUTUBE_TESTS, reason="YouTube tests cannot run in GH") +@pytest.mark.skipif(DISABLE_E2E_TESTS, reason="YouTube tests cannot run in GH") class TestSubtitles: def test_subtitle_lang_variable_partial_validates(self, default_config): default_config_dict = default_config.as_dict() diff --git a/tests/e2e/presets/test_bilateral.py b/tests/e2e/presets/test_bilateral.py index 8799c2e9..64c785d2 100644 --- a/tests/e2e/presets/test_bilateral.py +++ b/tests/e2e/presets/test_bilateral.py @@ -2,7 +2,7 @@ from typing import Dict import pytest from expected_transaction_log import assert_transaction_log_matches -from resources import DISABLE_YOUTUBE_TESTS +from resources import DISABLE_E2E_TESTS from ytdl_sub.config.config_file import ConfigFile from ytdl_sub.subscriptions.subscription import Subscription @@ -51,7 +51,7 @@ def tv_show_collection_bilateral_dict(output_directory): } -@pytest.mark.skipif(DISABLE_YOUTUBE_TESTS, reason="YouTube tests cannot run in GH") +@pytest.mark.skipif(DISABLE_E2E_TESTS, reason="YouTube tests cannot run in GH") class TestBilateral: def test_tv_show_by_date_downloads_bilateral( self, diff --git a/tests/e2e/presets/test_soundcloud.py b/tests/e2e/presets/test_soundcloud.py index 15c6d7d6..e333c1b5 100644 --- a/tests/e2e/presets/test_soundcloud.py +++ b/tests/e2e/presets/test_soundcloud.py @@ -4,6 +4,7 @@ import pytest from conftest import assert_logs from expected_download import assert_expected_downloads from expected_transaction_log import assert_transaction_log_matches +from resources import DISABLE_E2E_TESTS from ytdl_sub.downloaders.ytdlp import YTDLP from ytdl_sub.subscriptions.subscription import Subscription @@ -23,6 +24,7 @@ def subscription_dict(output_directory): } +@pytest.mark.skipif(DISABLE_E2E_TESTS, reason="Soundcloud tests cannot run in GH") class TestSoundcloudDiscography: """ Downloads my (bad) SC recordings I made. Ensure the above files exist and have the diff --git a/tests/e2e/youtube/test_channel.py b/tests/e2e/youtube/test_channel.py index dc73af1f..329c26ad 100644 --- a/tests/e2e/youtube/test_channel.py +++ b/tests/e2e/youtube/test_channel.py @@ -3,7 +3,7 @@ from typing import Callable, Dict import pytest from expected_download import assert_expected_downloads from expected_transaction_log import assert_transaction_log_matches -from resources import DISABLE_YOUTUBE_TESTS +from resources import DISABLE_E2E_TESTS from ytdl_sub.config.config_file import ConfigFile from ytdl_sub.subscriptions.subscription import Subscription @@ -42,7 +42,7 @@ def channel_preset_dict(output_directory): } -@pytest.mark.skipif(DISABLE_YOUTUBE_TESTS, reason="YouTube tests cannot run in GH") +@pytest.mark.skipif(DISABLE_E2E_TESTS, reason="YouTube tests cannot run in GH") class TestChannel: """ Downloads my old minecraft youtube channel. Ensure the above files exist and have the diff --git a/tests/e2e/youtube/test_video.py b/tests/e2e/youtube/test_video.py index 30cbe186..ac134b3e 100644 --- a/tests/e2e/youtube/test_video.py +++ b/tests/e2e/youtube/test_video.py @@ -1,7 +1,7 @@ import pytest from expected_download import assert_expected_downloads from expected_transaction_log import assert_transaction_log_matches -from resources import DISABLE_YOUTUBE_TESTS +from resources import DISABLE_E2E_TESTS from ytdl_sub.subscriptions.subscription import Subscription @@ -30,7 +30,7 @@ def single_video_preset_dict(output_directory): } -@pytest.mark.skipif(DISABLE_YOUTUBE_TESTS, reason="YouTube tests cannot run in GH") +@pytest.mark.skipif(DISABLE_E2E_TESTS, reason="YouTube tests cannot run in GH") class TestYoutubeVideo: @pytest.mark.parametrize("dry_run", [True, False]) def test_single_video_download( diff --git a/tests/resources.py b/tests/resources.py index a327be02..d7861a40 100644 --- a/tests/resources.py +++ b/tests/resources.py @@ -4,7 +4,7 @@ import shutil from pathlib import Path from typing import Dict -DISABLE_YOUTUBE_TESTS: bool = True +DISABLE_E2E_TESTS: bool = True REGENERATE_FIXTURES: bool = False RESOURCE_PATH: Path = Path("tests") / "resources"