From 3b79a7ccaed5fc65547ebee40edca212a1b876bf Mon Sep 17 00:00:00 2001
From: CatDuck <129601174+catduckgnaf@users.noreply.github.com>
Date: Wed, 30 Aug 2023 14:28:58 -0400
Subject: [PATCH] [FEATURE] Add `max_1080p` prebuilt preset (#690)

* Fix Plex MP4

No WebM, Best quality, No AV1 either

* Fixed because I am idiot

Forcing Plex to download only MP4 and 1080P. More efficient then downloading Webm and converting. Plex does not direct Play AV1 currently anyway.

* Plex Update

Default will get best video in H265 or H264, if neither are available, it will get next best video. All MP4, no limit on resolution.

Plex_tv_show_av1 will allow for absolute best possible resolution in any codec as long as its MP4, including Av1 which is not currently supported in Plex.

Without AV1 is considered default, for maximum compatibility at this time.

* EBUATK

Incorrect setting on Av1, fixed.

* Removed Av1 Preset

* adding common 1080p MAX preset

max_1080_video_quality:

* removed remux video

Removed remux video
Shortened preset name.

* Update presets.rst

Update presets.rst documentation to reflect the "max_1080P" preset

* remove remux_video

* Title Change for Clarity

* Update presets.rst

---------

Co-authored-by: catduckgnaf <128985786+cellardoor452@users.noreply.github.com>
---
 docs/presets.rst                                  | 8 ++++++++
 src/ytdl_sub/prebuilt_presets/helpers/common.yaml | 6 +++++-
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/docs/presets.rst b/docs/presets.rst
index 584a14ba..b69a019a 100644
--- a/docs/presets.rst
+++ b/docs/presets.rst
@@ -153,6 +153,14 @@ it into an MP4 container:
 
 * ``best_video_quality``
 
+
+Max 1080p
+^^^^^^^^^^^^^^^^^^
+
+Add the following preset to download the best available audio and video quality, with the video not greater than 1080p, and remux it into an MP4 container:
+
+* ``max_1080p``
+
 Chunk Initial Download
 ^^^^^^^^^^^^^^^^^^^^^^
 
diff --git a/src/ytdl_sub/prebuilt_presets/helpers/common.yaml b/src/ytdl_sub/prebuilt_presets/helpers/common.yaml
index 22e2d627..fda25402 100644
--- a/src/ytdl_sub/prebuilt_presets/helpers/common.yaml
+++ b/src/ytdl_sub/prebuilt_presets/helpers/common.yaml
@@ -6,7 +6,11 @@ presets:
     ytdl_options:
       format: "bestvideo+bestaudio/best"
       merge_output_format: "mp4"
-      remux_video: "mp4"
+
+  max_1080p:
+    ytdl_options:
+      format: "(bv*[height<=1080]+bestaudio/best[height<=1080])"
+      merge_output_format: "mp4"
 
   chunk_initial_download:
     ytdl_options: