danvics/ytdl-sub
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

e2e all passing!

Browse source
This commit is contained in:
Jesse Bannon 2023-12-13 09:42:57 -08:00
parent b9888a969e
commit 2c04d7ce6f
2 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/ytdl_sub/plugins/split_by_chapters.py
View file

@ -113,7 +113,7 @@ class SplitByChaptersOptions(OptionsDictValidator):
class SplitByChaptersPlugin(SplitPlugin[SplitByChaptersOptions]): class SplitByChaptersPlugin(SplitPlugin[SplitByChaptersOptions]):
plugin_options_type = SplitByChaptersOptions plugin_options_type = SplitByChaptersOptions
def modify_entry(self, entry: Entry) -> Optional[Entry]: def _non_split_entry(self, entry: Entry) -> Entry:
entry.add( entry.add(
{ {
"chapter_title": f"{{ {v.title.variable_name} }}", "chapter_title": f"{{ {v.title.variable_name} }}",
@ -178,7 +178,8 @@ class SplitByChaptersPlugin(SplitPlugin[SplitByChaptersOptions]):
# If no chapters, do not split anything # If no chapters, do not split anything
if not chapters.contains_any_chapters(): if not chapters.contains_any_chapters():
if self.plugin_options.when_no_chapters == "pass": if self.plugin_options.when_no_chapters == "pass":
return [(entry, FileMetadata())] # Modify the entry t
return [(self._non_split_entry(entry), FileMetadata())]
if self.plugin_options.when_no_chapters == "drop": if self.plugin_options.when_no_chapters == "drop":
return [] return []

4
src/ytdl_sub/subscriptions/subscription_download.py
View file

@ -289,9 +289,7 @@ class SubscriptionDownload(BaseSubscription, ABC):
self._cleanup_entry_files(split_entry) self._cleanup_entry_files(split_entry)
# Have the split_plugin modify the parent entry before sending it to deletion self._cleanup_entry_files(entry)
# This is needed to resolve any variables that may be needed to delete
self._cleanup_entry_files(split_plugin.modify_entry(entry))
def _process_subscription( def _process_subscription(
self, self,