diff --git a/src/ytdl_sub/cli/main_args_parser.py b/src/ytdl_sub/cli/main_args_parser.py index bd697521..fc13fadf 100644 --- a/src/ytdl_sub/cli/main_args_parser.py +++ b/src/ytdl_sub/cli/main_args_parser.py @@ -75,7 +75,8 @@ class MainArguments: # SHARED OPTIONS def _add_shared_arguments(arg_parser: argparse.ArgumentParser, suppress_defaults: bool) -> None: """ - Add shared arguments to sub parsers + Add shared arguments to sub parsers. Needed to be able to specify args after positional args. + i.e. support both ``ytdl-sub --dry-run sub`` and ``ytdl-sub sub --dry-run`` Parameters ---------- @@ -98,6 +99,7 @@ def _add_shared_arguments(arg_parser: argparse.ArgumentParser, suppress_defaults action="store_true", help="preview what a download would output, " "does not perform any video downloads or writes to output directories", + default=argparse.SUPPRESS if suppress_defaults else False, ) arg_parser.add_argument( MainArguments.LOG_LEVEL.short, diff --git a/tests/expected_transaction_log.py b/tests/expected_transaction_log.py index 75646f6f..7c589dcf 100644 --- a/tests/expected_transaction_log.py +++ b/tests/expected_transaction_log.py @@ -1,4 +1,5 @@ import os +from pathlib import Path from typing import List from resources import REGENERATE_FIXTURES @@ -10,7 +11,7 @@ _TRANSACTION_LOG_SUMMARY_PATH = RESOURCE_PATH / "transaction_log_summaries" def assert_transaction_log_matches( - output_directory: str, + output_directory: Path, transaction_log: FileHandlerTransactionLog, transaction_log_summary_file_name: str, regenerate_transaction_log: bool = REGENERATE_FIXTURES,