danvics/ytdl-sub
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

work on later

Browse source
This commit is contained in:
jbannon 2022-07-22 04:57:10 +00:00
parent 079994c003
commit 17586aa9bd
1 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/ytdl_sub/downloaders/soundcloud/albums_and_singles.py
View file

@ -1,4 +1,4 @@
from typing import Dict
from typing import Dict, Optional
from typing import List
from ytdl_sub.downloaders.soundcloud.abc import SoundcloudDownloader
@ -6,6 +6,7 @@ from ytdl_sub.downloaders.soundcloud.abc import SoundcloudDownloaderOptions
from ytdl_sub.entries.soundcloud import SoundcloudAlbum
from ytdl_sub.entries.soundcloud import SoundcloudTrack
from ytdl_sub.validators.url_validator import SoundcloudUsernameUrlValidator
from ytdl_sub.validators.validators import BoolValidator
class SoundcloudAlbumsAndSinglesDownloadOptions(SoundcloudDownloaderOptions):
@ -35,6 +36,9 @@ class SoundcloudAlbumsAndSinglesDownloadOptions(SoundcloudDownloaderOptions):
self._url = self._validate_key(
key="url", validator=SoundcloudUsernameUrlValidator
).username_url
self._download_individually = self._validate_key_if_present(
"download_individually", BoolValidator, default=True
)
@property
def url(self) -> str:
@ -43,6 +47,15 @@ class SoundcloudAlbumsAndSinglesDownloadOptions(SoundcloudDownloaderOptions):
"""
return self._url
@property
def download_individually(self) -> Optional[bool]:
"""
Optional. Downloads files from the channel individually instead of in bulk. Setting to True
is safer when downloading large amounts of videos in case an error occurs. Downloading by
bulk (by setting to False) can increase speeds. Defaults to True.
"""
return self._download_individually.value
class SoundcloudAlbumsAndSinglesDownloader(
SoundcloudDownloader[SoundcloudAlbumsAndSinglesDownloadOptions]
@ -120,7 +133,8 @@ class SoundcloudAlbumsAndSinglesDownloader(
artist_albums_url = self.artist_albums_url(artist_url=self.download_options.url)
artist_tracks_url = self.artist_tracks_url(artist_url=self.download_options.url)
# Albums do not need to download anything since tracks contain all album tracks
# Albums do not need to download anything since tracks contain all album tracks.
# We just need to get the metadata from the album itself
album_entry_dicts = self.extract_info_via_info_json(
ytdl_options_overrides={
"skip_download": True,