From 11be1192610336f7d4880501fc57a90bf61873ee Mon Sep 17 00:00:00 2001 From: Jesse Bannon Date: Wed, 25 Oct 2023 11:36:51 -0700 Subject: [PATCH] [BUGFIX] Do not set music_directory in prebuilt presets (#783) New music prebuilt presets had set `music_directory`, which is bad practice since it's not visible to the user which directory it would use. This forces `music_directory` to be set either in the user's config or subscription file --- src/ytdl_sub/prebuilt_presets/music/music.yaml | 4 +++- tests/unit/prebuilt_presets/test_prebuilt_presets.py | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/ytdl_sub/prebuilt_presets/music/music.yaml b/src/ytdl_sub/prebuilt_presets/music/music.yaml index ca6683b9..74db0da3 100644 --- a/src/ytdl_sub/prebuilt_presets/music/music.yaml +++ b/src/ytdl_sub/prebuilt_presets/music/music.yaml @@ -32,6 +32,9 @@ presets: - "{track_genre}" overrides: +# MUST DEFINE: +# music_directory + # Subscription overrides subscription_indent_1: "Unset" # genre url: "{subscription_value}" @@ -48,7 +51,6 @@ presets: track_genre: "{subscription_indent_1}" # Directory Overrides - music_directory: "/music" artist_dir: "{track_artist_sanitized}" album_dir: "[{track_year}] {track_album_sanitized}" track_file_name: "{track_number_padded} - {track_title_sanitized}.{ext}" diff --git a/tests/unit/prebuilt_presets/test_prebuilt_presets.py b/tests/unit/prebuilt_presets/test_prebuilt_presets.py index c75692dd..03225dca 100644 --- a/tests/unit/prebuilt_presets/test_prebuilt_presets.py +++ b/tests/unit/prebuilt_presets/test_prebuilt_presets.py @@ -360,6 +360,7 @@ class TestPrebuiltMusicPresets: music_preset, ], "overrides": { + "music_directory": "/music", "subscription_value": "https://your.name.here", }, },