949070ce73
The audiophile preset (fallback_enabled=False) still shipped a "FLAC 16-bit" target in its ladder, so 16-bit FLAC matched and imported even though the name implies hi-res-only. Split the ladder: audiophile now uses a strict 24-bit FLAC list; balanced keeps 24-bit + 16-bit + MP3. Gives users a one-click strict "24-bit only" profile that actually rejects 16-bit/lossy. Not a matches_target bug — that correctly rejects 16-bit vs a 24-bit target; the leak was the preset's target LIST including 16-bit (+ fallback accepting off-list lossy like MP3-128). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
33 lines
1.1 KiB
Python
33 lines
1.1 KiB
Python
"""Quality presets — the built-in ranked-target ladders behind the preset
|
|
buttons. `audiophile` must be STRICT hi-res (no 16-bit, no lossy, fallback off)
|
|
so a user who wants "24-bit only" gets it in one click; `balanced` keeps the
|
|
fuller ladder (16-bit + MP3) with fallback on.
|
|
"""
|
|
|
|
from database.music_database import MusicDatabase
|
|
|
|
|
|
def _preset(name):
|
|
# get_quality_preset doesn't touch self/DB — call unbound to avoid setup.
|
|
return MusicDatabase.get_quality_preset(None, name)
|
|
|
|
|
|
def _labels(profile):
|
|
return [t['label'] for t in profile['ranked_targets']]
|
|
|
|
|
|
def test_audiophile_is_strict_24bit_only():
|
|
p = _preset('audiophile')
|
|
assert p['fallback_enabled'] is False
|
|
labels = _labels(p)
|
|
assert all('24-bit' in l for l in labels) # only 24-bit FLAC
|
|
assert 'FLAC 16-bit' not in labels
|
|
assert not any('MP3' in l for l in labels)
|
|
|
|
|
|
def test_balanced_still_includes_16bit_and_mp3():
|
|
p = _preset('balanced')
|
|
labels = _labels(p)
|
|
assert 'FLAC 16-bit' in labels
|
|
assert any('MP3' in l for l in labels)
|
|
assert p['fallback_enabled'] is True
|