BoulderBadgeDad e4b5cbbe60 Wishlist: unify batch-row construction into make_wishlist_batch_row ... The auto and manual wishlist flows each built the same ~20-field download_batches row in separate places (auto album, auto residual, manual placeholder, manual sub-batches) — four near-identical literals that could (and did) drift apart, producing subtly different batch shapes between the flows. Extract make_wishlist_batch_row() as the single source of truth: it emits the consistent core field set, with the genuinely per-flow differences as explicit arguments — initial phase ('queued' for auto / 'analysis' for manual), the auto-only auto_initiated/auto_processing_timestamp/current_cycle via extra_fields, and album-vs-residual contexts. All four sites now go through it, so every wishlist batch has an IDENTICAL shape (this also removes the field drift that confused the modal-hydration code). Deliberately NOT unified — and left explicit in each caller, per the 'don't cargo-cult genuinely-different code' principle: the grouping decision (auto groups only on the albums cycle), batch-id allocation (manual reuses the caller's placeholder id for the first sub-batch), and dispatch (auto parallel-submits album batches to the dedicated pool + residual to the shared pool; manual runs them serially on one thread). Those are real behavioral differences, not duplication. Behavior-preserving: verified safe to normalize the row shape (grep confirmed every reader uses .get() with defaults, no key-presence checks). The existing auto (test_automation.py) and manual (test_manual_download.py) characterization suites stay green = differential proof of identical behavior. Adds test_batch_factory.py (core fields, album/residual, extra_fields, no shared mutable state, consistent key shape). 131 wishlist tests pass.		2026-05-29 16:55:31 -07:00
..
artists
automation	Auto-Sync: fix LB pipelines stuck on "Refreshing:" for 5+ minutes	2026-05-27 18:04:55 -07:00
database	Preserve Navidrome album cover art	2026-05-25 19:51:38 -07:00
discovery	Discovery lift (10/N): save_*_bubble_snapshot -> shared helper	2026-05-28 18:17:36 -07:00
downloads	Album-bundle staging: clean Soulseek copies + sweep orphans at startup	2026-05-27 22:18:42 -07:00
enrichment
imports	Wishlist: fix three regressions causing all imports to land as track 01 with no year	2026-05-27 15:39:22 -07:00
library
matching
media_server	Preserve Navidrome album cover art	2026-05-25 19:51:38 -07:00
metadata	Fix: import overwrites album-artist tag to "Unknown Artist" (#735)	2026-05-29 09:30:38 -07:00
playlists	Expose mirrored playlist source-ref health	2026-05-24 19:32:39 -07:00
search	Basic search: visual overhaul + per-source picker in hybrid mode	2026-05-28 10:22:07 -07:00
static	Auto-Sync Weekly Board: weekday schedules in the UI (PR 3/4)	2026-05-27 12:39:56 -07:00
stats
streaming
sync	Address Cin review: extract helpers, indexed pool fetch, tidy nits	2026-05-24 23:33:55 -07:00
text	Address Cin review: extract helpers, indexed pool fetch, tidy nits	2026-05-24 23:33:55 -07:00
tools
watchlist
webui	Fix missing album placeholder asset path	2026-05-22 08:34:42 -07:00
wishlist	Wishlist: unify batch-row construction into make_wishlist_batch_row	2026-05-29 16:55:31 -07:00
conftest.py	Split metadata source and Spotify status	2026-05-02 22:02:00 +03:00
test_acoustid_scanner.py	AcoustID scanner: multi-candidate match + duration guard + multi-value retag	2026-05-14 14:09:38 -07:00
test_acoustid_skip_logic.py	Fix: tasks showed Completed when file was quarantined	2026-05-03 18:28:32 -07:00
test_acoustid_version_mismatch.py	Reject AcoustID matches whose version disagrees with the expected track	2026-05-07 13:25:30 -07:00
test_album_bundle.py	Usenet bundle: writable staging dir + client→local path resolution (#721)	2026-05-29 02:04:47 -04:00
test_album_bundle_dispatch.py	Add Soulseek album bundle downloads	2026-05-23 15:08:21 -07:00
test_album_completeness_job.py
test_album_mbid_consistency.py
test_archive_pipeline.py
test_artist_full_detail_source_id.py	Fix: enhanced artist view 404s for library artists opened via source ID	2026-05-28 12:00:29 -07:00
test_artist_top_tracks_clients.py
test_audiodb_worker_stuck_track.py
test_auth_usage_throttle.py	test: auth last_used_at write throttle	2026-04-19 15:22:24 -07:00
test_auto_sync_js.py	Add node:test contract for auto-sync.js helpers	2026-05-25 00:01:34 -07:00
test_config_save_retry.py	Stop config retry tests from writing to the real DB	2026-04-30 14:07:00 -07:00
test_content_filter_regex.py
test_create_finding_dedup_counter.py	Repair job card badge — show pending count, not last-scan count	2026-05-07 08:28:17 -07:00
test_dashboard_events.py
test_database_io_resilience.py	Handle transient SQLite IO during maintenance	2026-05-21 17:50:30 -07:00
test_db_genres_json_normalization.py	DB: normalize legacy comma-separated genres to canonical JSON	2026-05-29 12:11:09 -07:00
test_db_migration_ledger.py	DB: add schema_migrations ledger + PRAGMA user_version backstop	2026-05-29 12:14:20 -07:00
test_db_watchlist_amazon_id_migration.py	DB: stop watchlist_artists rebuilds from dropping amazon_artist_id	2026-05-29 12:04:11 -07:00
test_debug_info_services.py
test_discogs_collection_source.py	Discogs: strip artist disambiguation suffixes at every name surface (#634)	2026-05-27 09:05:47 -07:00
test_discogs_track_count.py
test_discover_section_controller_js.py
test_download_orchestrator_soundcloud.py
test_download_plugin_conformance.py	Add torrent usenet PR notes and test updates	2026-05-21 15:28:48 -07:00
test_downloads_pagination.py	Lift shared runtime state into core	2026-04-27 19:54:44 +03:00
test_duplicate_detector_mount_paths.py	Filter same-physical-file duplicates from duplicate detector	2026-04-30 14:06:10 -07:00
test_duplicate_detector_slskd_dedup.py
test_enrichment_services.py
test_featured_artist_completion.py
test_hifi_instance_methods.py	Fix "no such table: hifi_instances" via defensive lazy-create	2026-05-06 17:49:44 -07:00
test_hls_parsing.py
test_image_cache.py
test_import_album_match_endpoint.py	Lift auto-import matching to testable helper + pin contracts	2026-05-09 09:13:23 -07:00
test_import_singles_parallel.py
test_integrity_failure_marks_task_failed.py
test_lb_series_detect.py	Roll LB Weekly / Top series into single rolling mirrors (Phase 1c.2.1)	2026-05-26 15:49:49 -07:00
test_library_disk_usage.py	Repair stale media schema during refresh	2026-05-21 17:41:54 -07:00
test_library_reorganize.py	Rewrite Library Reorganize job to delegate to per-album planner	2026-05-06 21:18:20 -07:00
test_library_reorganize_orchestrator.py
test_library_tag_payload.py	Add _build_library_tag_db_data helper	2026-05-25 18:48:45 -07:00
test_library_track_identity.py	Make extract_external_ids recognize all source-tagging conventions	2026-05-02 18:26:12 -07:00
test_lidarr_download_client.py
test_listenbrainz_manager.py	Auto-Sync: fix LB pipelines stuck on "Refreshing:" for 5+ minutes	2026-05-27 18:04:55 -07:00
test_listening_stats_batch_queries.py
test_lyrics_reembed_from_sidecar.py
test_manual_library_match.py	Honor manual library matches across source labels	2026-05-18 16:32:38 -07:00
test_manual_pick_no_auto_retry.py	Add torrent and usenet release staging support	2026-05-21 14:22:21 -07:00
test_manual_search_endpoint.py	Manual picks: stream results, don't auto-retry, fix stuck-at-0%	2026-05-08 15:12:58 -07:00
test_matching_engine_cjk.py	Fix: duplicate tracks in albums with Japanese / CJK titles (#722)	2026-05-28 08:53:43 -07:00
test_missing_cover_art.py	Fix: maintenance findings badge inflated when scan dedup-skipped	2026-05-04 08:55:13 -07:00
test_orphan_file_detector.py	Fix Picard albumartist orphan false positives	2026-05-22 08:43:57 -07:00
test_personalized_api.py	Personalized playlists (3/N): standardized API endpoints	2026-05-15 17:15:25 -07:00
test_personalized_generators_curated.py	Personalized playlists (2/N): all 8 generators wired through manager	2026-05-15 17:02:08 -07:00
test_personalized_generators_singletons.py	Personalized playlists (2/N): all 8 generators wired through manager	2026-05-15 17:02:08 -07:00
test_personalized_generators_variants.py	Personalized playlists (2/N): all 8 generators wired through manager	2026-05-15 17:02:08 -07:00
test_personalized_manager.py
test_personalized_playlists_id_gate.py
test_playlist_sources_adapters.py	Auto-Sync: fix LB pipelines stuck on "Refreshing:" for 5+ minutes	2026-05-27 18:04:55 -07:00
test_provenance_id_persistence.py	Persist source IDs at download time + backfill onto tracks on sync	2026-05-02 17:44:10 -07:00
test_prowlarr_client.py	test: cover Prowlarr + torrent + usenet adapters	2026-05-20 15:43:18 -07:00
test_qobuz_credential_sync.py	Address Copilot review nits	2026-05-05 11:22:01 -07:00
test_qobuz_playlists.py	Fetch all Qobuz favorite tracks for discovery	2026-05-24 01:17:38 -07:00
test_reorganize_db_methods.py	Reorganize queue: race + dedupe fixes from kettui review	2026-04-26 08:40:24 -07:00
test_reorganize_orphan_format_handling.py
test_reorganize_queue.py	Reorganize queue: race + dedupe fixes from kettui review	2026-04-26 08:40:24 -07:00
test_reorganize_runner.py
test_reorganize_tag_source.py
test_reorganize_unknown_artist_hint.py
test_repair_worker_album_fill.py
test_repair_worker_unresolvable_folder_error.py	Album Completeness: surface diagnostic when resolver can't find album folder	2026-05-12 14:04:15 -07:00
test_replaygain_summary_parse.py
test_request_cleanup_timer.py
test_runtime_state.py
test_script_split_integrity.py	Add node:test contract for auto-sync.js helpers	2026-05-25 00:01:34 -07:00
test_server_playlist_append_mode.py
test_socketio_cors.py
test_soulseek_search_throttle.py
test_soundcloud_client.py	Lift shared download dataclasses + boot via singleton factory	2026-05-05 09:08:39 -07:00
test_source_ids_registry.py	Source IDs: add canonical registry, adopt at the highest-value sites	2026-05-29 12:19:59 -07:00
test_spa_deep_linking.py	feat: artist-detail deep linking — /artist-detail/:source/:id	2026-05-18 13:07:54 -07:00
test_staging_album_provenance.py
test_status_engine_fallback.py	Manual picks: stream results, don't auto-retry, fix stuck-at-0%	2026-05-08 15:12:58 -07:00
test_sync_discovery_scan_events.py	Realign test file names	2026-04-17 21:25:01 +03:00
test_tag_writer_multi_artist.py	AcoustID scanner: multi-candidate match + duration guard + multi-value retag	2026-05-14 14:09:38 -07:00
test_tidal_album_tracks.py
test_tidal_auth_instructions.py	Show Tidal callback port (not Spotify's) in auth instructions	2026-04-30 20:54:06 -07:00
test_tidal_auth_redirect_uri.py	Honor configured Tidal redirect_uri, drop request-host fallback	2026-05-02 19:20:18 -07:00
test_tidal_collection_tracks.py
test_tidal_favorite_albums_artists.py
test_tidal_qualifier_filter.py	Fix MTV Unplugged & live-album false-quarantine pipeline	2026-05-14 12:14:31 -07:00
test_tidal_search_shortening.py
test_tool_progress_events.py
test_torrent_client_adapters.py
test_torrent_usenet_plugins.py	Fix: Usenet bundle stuck at 99%/100% — SAB reports post-processing in History as non-terminal (#721)	2026-05-29 00:49:02 -04:00
test_track_artist_matching.py
test_track_number_repair.py
test_track_search_single_query.py
test_unknown_artist_fixer.py	fix(repair): rewire Unknown Artist Fixer deferred imports (#646)	2026-05-19 22:09:15 -07:00
test_usenet_client_adapters.py	Fix: Usenet bundle stuck at 99%/100% — SAB reports post-processing in History as non-terminal (#721)	2026-05-29 00:49:02 -04:00
test_watchlist_album_match.py
test_watchlist_bulk_add.py	Complete MusicBrainz watchlist source parity	2026-05-18 19:19:25 -07:00
test_watchlist_scanner_scan.py
test_websocket_client_transport.py
test_websocket_infrastructure.py
test_wishlist_pagination.py	test: wishlist SQL pagination and category filter	2026-04-19 15:22:24 -07:00
test_worker_existing_id_marks_matched.py
test_worker_utils_album_track_count.py
test_youtube_ffmpeg_no_eager_download.py	ffmpeg gate also covers is_available — fixes the actual leak path	2026-05-08 15:46:31 -07:00
test_youtube_search_dash_query.py	Escape dash-leading YouTube search queries	2026-05-24 08:54:47 -07:00