fe78a3cdc3
Remove the per-source download-quality dropdowns (Tidal/HiFi/Qobuz/Deezer/
Amazon) — with the global ranked-targets system they were redundant and
conflicting. Add quality_tier_for_source(): picks the LOWEST source tier
that satisfies the user's top target (respects the quality ceiling, saves
bandwidth) or the source's max as best effort. Every source's search +
download + retry path now derives its tier from the global profile instead
of config_manager.get('<source>_download.quality').
Settings keep the per-source allow_fallback toggles; the quality selects are
replaced with a note pointing at Quality Profile.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
62 lines
2.3 KiB
Python
62 lines
2.3 KiB
Python
"""quality_tier_for_source — derive a source's requested download tier from
|
|
the GLOBAL quality profile instead of a per-source setting.
|
|
|
|
Rule: pick the LOWEST source tier that satisfies the user's top (most
|
|
preferred) target — respecting the user's quality ceiling and saving
|
|
bandwidth — or the source's max tier when none can satisfy it (best effort).
|
|
"""
|
|
|
|
import pytest
|
|
|
|
import core.quality.source_map as sm
|
|
from core.quality.model import QualityTarget
|
|
|
|
|
|
def _patch_targets(monkeypatch, targets, fallback=True):
|
|
monkeypatch.setattr(sm, 'load_profile_targets', lambda: (targets, fallback))
|
|
|
|
|
|
T_FLAC24_96 = [QualityTarget(label='', format='flac', bit_depth=24, min_sample_rate=96000)]
|
|
T_FLAC24_192 = [QualityTarget(label='', format='flac', bit_depth=24, min_sample_rate=192000)]
|
|
T_FLAC16 = [QualityTarget(label='', format='flac', bit_depth=16)]
|
|
T_MP3_320 = [QualityTarget(label='', format='mp3', min_bitrate=320)]
|
|
|
|
|
|
def test_tidal_hires_when_top_wants_24_96(monkeypatch):
|
|
_patch_targets(monkeypatch, T_FLAC24_96)
|
|
assert sm.quality_tier_for_source('tidal') == 'hires'
|
|
|
|
|
|
def test_tidal_lossless_respects_16bit_ceiling(monkeypatch):
|
|
# User caps at 16-bit → request lossless, NOT hires (saves bandwidth).
|
|
_patch_targets(monkeypatch, T_FLAC16)
|
|
assert sm.quality_tier_for_source('tidal') == 'lossless'
|
|
|
|
|
|
def test_tidal_best_effort_max_when_unsatisfiable(monkeypatch):
|
|
# Source maxes at 24/96 but user wants 24/192 → best effort = max tier.
|
|
_patch_targets(monkeypatch, T_FLAC24_192)
|
|
assert sm.quality_tier_for_source('tidal') == 'hires'
|
|
|
|
|
|
def test_no_targets_requests_max(monkeypatch):
|
|
_patch_targets(monkeypatch, [])
|
|
assert sm.quality_tier_for_source('tidal') == 'hires'
|
|
assert sm.quality_tier_for_source('deezer') == 'flac'
|
|
|
|
|
|
def test_deezer_flac_and_mp3(monkeypatch):
|
|
_patch_targets(monkeypatch, T_FLAC16)
|
|
assert sm.quality_tier_for_source('deezer') == 'flac'
|
|
_patch_targets(monkeypatch, T_MP3_320)
|
|
assert sm.quality_tier_for_source('deezer') == 'mp3_320'
|
|
|
|
|
|
def test_qobuz_hires_max(monkeypatch):
|
|
_patch_targets(monkeypatch, T_FLAC24_192)
|
|
assert sm.quality_tier_for_source('qobuz') == 'hires_max'
|
|
|
|
|
|
def test_unknown_source_returns_default(monkeypatch):
|
|
_patch_targets(monkeypatch, T_FLAC16)
|
|
assert sm.quality_tier_for_source('nope', default='x') == 'x'
|