ddde6cba68
Boulder: 'youtube should have its own quality profile — there are not many options.'
Right — YouTube is grabbed with yt-dlp, not scene/p2p releases, so the Radarr-style
ladder/cutoff/rejects/HDR-audio tiers are meaningless. Added a small, separate profile:
- core/video/youtube_quality.py (pure, isolated): max_resolution ceiling
(best…360p), video_codec (any/av1/vp9/h264, soft), container (mp4/mkv/webm),
prefer_60fps, allow_hdr. normalize/load/save → video.db youtube_quality_profile.
- api/video/downloads.py: GET/POST /downloads/youtube-quality.
- UI: a 'YouTube Quality' card on the Downloads tab (data-video-only) — resolution
dropdown + codec/container segmented + 60fps/HDR checks, reusing the vq-* styles.
Wired into onPageShown + the save-all chain.
The (later-phase) yt-dlp downloader maps these to a format/format_sort selection.
9 new tests green, isolation guard green, ruff clean, JS/HTML balance clean.
81 lines
2.5 KiB
Python
81 lines
2.5 KiB
Python
"""YouTube download quality profile — the small, yt-dlp-shaped seam (resolution
|
|
ceiling + codec + container + 60fps/HDR flags), isolated from the music side and
|
|
separate from the main Radarr-style video quality profile."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
|
|
from core.video.youtube_quality import (
|
|
CODECS,
|
|
CONTAINERS,
|
|
RESOLUTIONS,
|
|
default_profile,
|
|
load,
|
|
normalize,
|
|
save,
|
|
)
|
|
|
|
|
|
def test_default_shape():
|
|
d = default_profile()
|
|
assert d["max_resolution"] == "1080p" and d["video_codec"] == "any"
|
|
assert d["container"] == "mp4"
|
|
assert d["prefer_60fps"] is True and d["allow_hdr"] is False
|
|
|
|
|
|
def test_constants():
|
|
assert "best" in RESOLUTIONS and "2160p" in RESOLUTIONS # no-cap + 4K offered
|
|
assert CODECS == ("any", "av1", "vp9", "h264")
|
|
assert CONTAINERS == ("mp4", "mkv", "webm")
|
|
|
|
|
|
def test_normalize_garbage_returns_default():
|
|
assert normalize(None) == default_profile()
|
|
assert normalize("nope") == default_profile()
|
|
assert normalize(42) == default_profile()
|
|
|
|
|
|
def test_normalize_validates_enums_and_coerces_flags():
|
|
out = normalize({"max_resolution": "2160p", "video_codec": "av1",
|
|
"container": "mkv", "prefer_60fps": 0, "allow_hdr": 1})
|
|
assert out["max_resolution"] == "2160p" and out["video_codec"] == "av1"
|
|
assert out["container"] == "mkv"
|
|
assert out["prefer_60fps"] is False and out["allow_hdr"] is True
|
|
|
|
|
|
def test_normalize_rejects_unknown_values():
|
|
bad = normalize({"max_resolution": "9000p", "video_codec": "theora", "container": "avi"})
|
|
assert bad["max_resolution"] == "1080p" # falls back to default
|
|
assert bad["video_codec"] == "any"
|
|
assert bad["container"] == "mp4"
|
|
|
|
|
|
class _FakeDB:
|
|
def __init__(self):
|
|
self._kv = {}
|
|
|
|
def get_setting(self, key, default=None):
|
|
return self._kv.get(key, default)
|
|
|
|
def set_setting(self, key, value):
|
|
self._kv[key] = value
|
|
|
|
|
|
def test_load_default_when_unset():
|
|
assert load(_FakeDB()) == default_profile()
|
|
|
|
|
|
def test_save_then_load_roundtrips_normalized():
|
|
db = _FakeDB()
|
|
saved = save(db, {"max_resolution": "best", "container": "webm", "allow_hdr": True})
|
|
assert saved["max_resolution"] == "best" and saved["container"] == "webm"
|
|
assert saved["allow_hdr"] is True
|
|
assert json.loads(db.get_setting("youtube_quality_profile"))["container"] == "webm"
|
|
assert load(db) == saved
|
|
|
|
|
|
def test_load_recovers_from_corrupt_json():
|
|
db = _FakeDB()
|
|
db.set_setting("youtube_quality_profile", "{nope")
|
|
assert load(db) == default_profile()
|