cf5461f2f1
`_create_finding` silently dedup-skipped re-discovered issues but the caller incremented `findings_created` regardless. So a re-scan that found the same issues as a prior scan reported 364 findings in the badge while 0 NEW pending rows hit the db, leaving the findings tab empty. `_create_finding` now returns bool (True on insert, False on dedup-skip / db error). All 16 repair jobs updated to only increment `findings_created` on True. Added `findings_skipped_dedup` counter surfaced in scan log: "Done: X scanned, 0 fixed, 0 findings (363 already existed), 0 errors". Also fixed a missing `job_id` kwarg in album_tag_consistency that was silently breaking finding creation for that scan. |
||
|---|---|---|
| .. | ||
| test_album_mbid_cache.py | ||
| test_artist_source_detail.py | ||
| test_artist_source_lookup.py | ||
| test_build_album_info_typed_path.py | ||
| test_discography_typed_path.py | ||
| test_enrichment_events.py | ||
| test_image_url_normalization.py | ||
| test_metadata_album_tracks.py | ||
| test_metadata_artist_image.py | ||
| test_metadata_cache.py | ||
| test_metadata_cache_batch_lookup.py | ||
| test_metadata_discography.py | ||
| test_metadata_enrichment.py | ||
| test_metadata_gap_filler.py | ||
| test_metadata_musicmap.py | ||
| test_metadata_registry.py | ||
| test_musicbrainz_search.py | ||
| test_runtime_bundle.py | ||
| test_typed_metadata_types.py | ||