BoulderBadgeDad 4039ec3573 #800: Write Tags must not overwrite a real file value with a placeholder ... A mis-grouped library track sits under a 'Various Artists' / '[Unknown Album]' record while the file itself is correctly tagged. Write Tags reads the DB and stamped that junk over the file — destroying the correct tags. (Rematching never helped: a match only stores a source-ID pointer, it never changes the local name/title the writer reads.) Guard: never replace a real file value with a placeholder. Added at both seams so preview and write agree: - build_tag_diff marks such a field protected/no-change (the preview no longer shows a wrong overwrite, and has_changes reflects reality), - write_tags_to_file reads the file's current values and skips the placeholder-over-real fields, preserving the file. Field-agnostic and direction-safe: the guard fires ONLY when the DB value is a placeholder AND the file holds a real one. A legitimate value still writes — including a genuine 'Various Artists' album artist on a real compilation, where the file has no conflicting real value, so the guard doesn't fire. Every write_tags_to_file caller writes DB->file as a correction, so blocking placeholder-over-real is correct for all of them (the download post-process uses a different path, embed_source_ids). 23 new tests (placeholder detection, the guard fn, build_tag_diff on the screenshot-#2 scenario, end-to-end FLAC write preserving real values and still overwriting with real ones). 113 existing repair/retag/tag tests pass.		2026-06-05 20:07:03 -07:00
..
artists
automation	Merge pull request #780 from kekkokk/feature/organize-by-playlist-library	2026-06-03 20:33:18 -07:00
discovery	#799: stop mirrored discovery from reverting a manual fix to Wing It	2026-06-05 11:07:32 -07:00
download_engine
download_plugins	Fix #796: Soulseek album bundle left completed files in slskd download folder	2026-06-04 21:56:07 -07:00
downloads	#797: stop AcoustID quarantining correct non-English-artist downloads	2026-06-05 16:02:01 -07:00
enrichment	Similar Artists enrichment worker (MusicMap → match → store) for library artists	2026-06-03 15:07:49 -07:00
imports	Remove the old Retag Tool (superseded by Library Re-tag job + Write Tags)	2026-06-04 09:33:03 -07:00
library	Auto-reconcile embedded IDs for new tracks on library scans	2026-06-05 18:31:11 -07:00
maintenance	Add one-off repair for source ids shared across multiple artists	2026-06-05 08:38:55 -07:00
matching	#797: stop AcoustID quarantining correct non-English-artist downloads	2026-06-05 16:02:01 -07:00
media_server
metadata	Tagging: write source IDs too (Write Tags button + library re-tag now complete)	2026-06-04 09:20:34 -07:00
personalized
playback	Player: log SoulSync web-player plays (recently-played + smart-radio recency)	2026-05-30 15:11:46 -07:00
playlists	PR #780 follow-ups: snapshot-based stale check + submit guard + dead code	2026-06-03 20:45:17 -07:00
radio	Player revamp Phase 2: smart radio ranking (play-count + popularity)	2026-05-30 08:47:18 -07:00
repair_jobs	Cover Art Filler: honor the configured cover-art sources too	2026-06-04 14:50:40 -07:00
search	#798: Spotify Free metadata mode — backend (opt-in, shared spotify tables)	2026-06-05 13:32:37 -07:00
stats
streaming	Player revamp Phase 3a: extract stream state into testable per-session store	2026-05-30 08:59:15 -07:00
sync	Fix #792: reconcile sync mode was clamped back to 'replace' in the backend	2026-06-04 15:57:40 -07:00
text	Fix #768: playlist sync editor refusing to match certain tracks	2026-06-02 10:16:21 -07:00
torrent_clients	Fix #790: torrent client URL without http:// scheme fails to connect	2026-06-04 11:57:53 -07:00
usenet_clients
watchlist
webui
wishlist	Fix organize-by-playlist downloads: library entries, wishlist, and stale Spotify cache	2026-06-03 10:26:32 +02:00
workers
acoustid_client.py	AcoustID: report errors honestly instead of masking them as 'Skipped'	2026-05-31 20:10:31 -07:00
acoustid_verification.py	#797: stop AcoustID quarantining correct non-English-artist downloads	2026-06-05 16:02:01 -07:00
album_consistency.py
amazon_client.py	Fix #759: Amazon enrichment floods when its public proxy is down	2026-06-01 13:10:51 -07:00
amazon_download_client.py
amazon_outage.py	Fix #759: Amazon enrichment floods when its public proxy is down	2026-06-01 13:10:51 -07:00
amazon_worker.py	Enrichment manager: 'process this group first' + refined hero header	2026-06-02 19:45:04 -07:00
api_call_tracker.py
archive_pipeline.py
artist_source_detail.py
artist_source_lookup.py	Fix artist-detail showing wrong artist when a source id is duplicated	2026-06-05 07:24:51 -07:00
audiodb_client.py
audiodb_worker.py	Tighten artist matching: 0.85 gate + shared uniqueness guard	2026-06-05 10:01:17 -07:00
auto_import_worker.py
automation_engine.py
connection_detect.py
connection_test.py
database_update_worker.py	Run auto-reconcile as a scan phase inside the running window	2026-06-05 19:10:31 -07:00
db_integrity.py	DB backups: verify integrity + never evict the last good backup	2026-05-30 21:13:04 -07:00
debug_info.py
deezer_client.py
deezer_download_client.py
deezer_worker.py	Tighten artist matching: 0.85 gate + shared uniqueness guard	2026-06-05 10:01:17 -07:00
discogs_client.py
discogs_worker.py	Tighten artist matching: 0.85 gate + shared uniqueness guard	2026-06-05 10:01:17 -07:00
download_orchestrator.py
genius_client.py
genius_worker.py	Enrichment manager: 'process this group first' + refined hero header	2026-06-02 19:45:04 -07:00
genre_filter.py
hifi_client.py
hydrabase_client.py
hydrabase_worker.py
image_cache.py	Image cache: reject truncated downloads instead of caching broken covers (#750)	2026-05-30 17:45:01 -07:00
itunes_client.py
itunes_worker.py	Tighten artist matching: 0.85 gate + shared uniqueness guard	2026-06-05 10:01:17 -07:00
jellyfin_client.py	Fix #792: 'reconcile' playlist sync mode (edit in place, keep image/description)	2026-06-04 15:15:49 -07:00
lastfm_client.py
lastfm_worker.py	Enrichment manager: 'process this group first' + refined hero header	2026-06-02 19:45:04 -07:00
library_reorganize.py	Canonical album version — Stage 3: Reorganizer prefers pinned canonical (read)	2026-06-02 11:45:31 -07:00
lidarr_download_client.py
listenbrainz_client.py
listenbrainz_manager.py
listening_stats_worker.py
lyrics_client.py
matching_engine.py
metadata_service.py
musicbrainz_client.py	MusicBrainz manual search: field-scope the artist in non-strict mode (#754)	2026-05-31 10:05:24 -07:00
musicbrainz_search.py
musicbrainz_service.py
musicbrainz_worker.py	Tighten artist matching: 0.85 gate + shared uniqueness guard	2026-06-05 10:01:17 -07:00
navidrome_client.py	Fix #792: 'reconcile' playlist sync mode (edit in place, keep image/description)	2026-06-04 15:15:49 -07:00
personalized_playlists.py
plex_client.py	Fix #792: 'reconcile' playlist sync mode (edit in place, keep image/description)	2026-06-04 15:15:49 -07:00
prowlarr_client.py
qobuz_client.py
qobuz_worker.py	Tighten artist matching: 0.85 gate + shared uniqueness guard	2026-06-05 10:01:17 -07:00
reorganize_queue.py
reorganize_runner.py
repair_worker.py	Library Re-tag: add light/full depth setting, default source to active, fix dropdown CSS	2026-06-04 10:21:30 -07:00
replaygain.py
runtime_state.py
seasonal_discovery.py
similar_artists_worker.py	Lint: fix ruff B905 (zip strict=) + S110 (try/except/pass) in similar-artists worker + perf endpoint	2026-06-03 16:35:19 -07:00
socketio_cors.py
soulid_worker.py
soulseek_client.py	Fix #796: Soulseek album bundle left completed files in slskd download folder	2026-06-04 21:56:07 -07:00
soulsync_client.py
soundcloud_client.py
source_ids.py	Source IDs: add canonical registry, adopt at the highest-value sites	2026-05-29 12:19:59 -07:00
spotify_client.py	#798: make Spotify Free opt-in (not auto-bridge) + clearer help text	2026-06-05 15:10:18 -07:00
spotify_free_metadata.py	#798: Spotify Free metadata mode — backend (opt-in, shared spotify tables)	2026-06-05 13:32:37 -07:00
spotify_public_api.py	SpotipyFree integration confirmed working (236 tracks live); deps + meta tweak	2026-06-02 22:50:04 -07:00
spotify_public_scraper.py	Diagnostics: route public-fetch logs to soulsync namespace + log HTTP status	2026-06-02 22:09:51 -07:00
spotify_worker.py	#798: Spotify Free as a rate-limit bridge for connected users (hybrid)	2026-06-05 14:00:50 -07:00
tag_writer.py	#800: Write Tags must not overwrite a real file value with a placeholder	2026-06-05 20:07:03 -07:00
tidal_client.py
tidal_download_client.py
tidal_worker.py	Tighten artist matching: 0.85 gate + shared uniqueness guard	2026-06-05 10:01:17 -07:00
watchlist_scanner.py	#798: Spotify Free metadata mode — backend (opt-in, shared spotify tables)	2026-06-05 13:32:37 -07:00
web_scan_manager.py
wishlist_service.py
worker_utils.py	Tighten artist matching: 0.85 gate + shared uniqueness guard	2026-06-05 10:01:17 -07:00
youtube_client.py