- Extract the import pipeline, album import, staging, path, file ops, guards, runtime state, side effects, and metadata enrichment out of . - Canonicalize the refactored import path around and remove legacy , , , and request shapes from the import endpoints. - Make album and track metadata lookups follow the configured provider priority instead of hard-coding Spotify, while still falling back when needed. - Update the import routes and frontend payloads to use the new core helpers. - Add coverage for the extracted helpers and the refactored import flows. PS. apologies to anyone who might check this commit out - the intention was to start small, but things kinda snowballed out of control at some point since the logic just kept going on and on, and everything kinda had to be changed all at once for it all to make any sense
47 lines
1.4 KiB
Python
47 lines
1.4 KiB
Python
from types import SimpleNamespace
|
|
|
|
from core import import_guards as guards
|
|
|
|
|
|
class _FakeDB:
|
|
def __init__(self, quality_profile):
|
|
self._quality_profile = quality_profile
|
|
|
|
def get_quality_profile(self):
|
|
return self._quality_profile
|
|
|
|
|
|
def test_check_flac_bit_depth_rejects_strict_mismatch(monkeypatch):
|
|
monkeypatch.setattr(
|
|
guards,
|
|
"MusicDatabase",
|
|
lambda: _FakeDB({"qualities": {"flac": {"bit_depth": "16", "bit_depth_fallback": False}}}),
|
|
)
|
|
monkeypatch.setattr(
|
|
guards,
|
|
"_get_config_manager",
|
|
lambda: SimpleNamespace(get=lambda _key, default=None: False),
|
|
)
|
|
|
|
context = {"_audio_quality": "FLAC 24bit", "track_info": {"name": "Song One"}}
|
|
|
|
assert guards.check_flac_bit_depth("/tmp/Song One.flac", context) == (
|
|
"FLAC bit depth mismatch: file is 24-bit, preference is 16-bit"
|
|
)
|
|
|
|
|
|
def test_check_flac_bit_depth_allows_fallback_when_enabled(monkeypatch):
|
|
monkeypatch.setattr(
|
|
guards,
|
|
"MusicDatabase",
|
|
lambda: _FakeDB({"qualities": {"flac": {"bit_depth": "16", "bit_depth_fallback": True}}}),
|
|
)
|
|
monkeypatch.setattr(
|
|
guards,
|
|
"_get_config_manager",
|
|
lambda: SimpleNamespace(get=lambda _key, default=None: False),
|
|
)
|
|
|
|
context = {"_audio_quality": "FLAC 24bit", "track_info": {"name": "Song One"}}
|
|
|
|
assert guards.check_flac_bit_depth("/tmp/Song One.flac", context) is None
|