53284ee7c8
Adds the per-kind generator modules and registers them with the
PlaylistKindRegistry so the manager's `refresh_playlist` can dispatch
to any of them.
Generators (each in its own module under
`core/personalized/generators/`):
Singletons (variant=''):
- hidden_gems -> wraps service.get_hidden_gems
- discovery_shuffle -> wraps service.get_discovery_shuffle
- popular_picks -> wraps service.get_popular_picks
Variant-bearing kinds:
- time_machine -> variant = decade label ('1980s', '1990s', ...).
Variant resolver returns 7 standard decades.
Generator parses '1980s' -> 1980 + delegates
to service.get_decade_playlist.
- genre_playlist -> variant = URL-safe genre key
('electronic_dance', 'hip_hop_rap', ...).
Resolver normalizes parent-genre keys from
service.GENRE_MAPPING; free-form keywords
pass through to service.get_genre_playlist.
- daily_mix -> variant = top-genre rank ('1' / '2' / '3' / '4').
Generator looks up user's Nth-ranked library
genre and returns discovery picks within it.
Library half (was a stub returning []) is
intentionally dropped: tracks table has no
source IDs, so library rows can't sync. Fixed
the stub to return [] cleanly without the
misleading log warning.
- fresh_tape -> Spotify Release Radar. Reads curated track
IDs from discovery_curated_playlists (tries
'release_radar_<source>' first, falls back to
'release_radar') and hydrates against the
discovery pool.
- archives -> Spotify Discover Weekly. Same hydration path
as fresh_tape but uses 'discovery_weekly'.
- seasonal_mix -> variant = season key ('halloween' / 'christmas'
/ 'valentines' / 'summer' / 'spring' / 'autumn').
Reads curated IDs via SeasonalDiscoveryService
then hydrates from seasonal_tracks (which
carries full track_data_json).
Each module:
- Defines `generate(deps, variant, config) -> List[Track]`.
- Defines `SPEC = PlaylistKindSpec(...)` and registers it on import
(idempotent — re-import safe via `if registry.get(...) is None`).
- For variant-bearing kinds, also defines `variant_resolver(deps)`.
Shared helpers in `_common.py`:
- `get_service(deps)` pulls the legacy
`PersonalizedPlaylistsService` instance (deps.service or
deps['service']).
- `coerce_tracks(rows)` runs each dict through `Track.from_dict`,
tolerates None / non-list inputs.
Tests (50 new, total 85 across personalized subsystem):
- Singletons: registration + display name + dispatch + limit
forwarding + empty/None tolerance + missing-deps error +
dict-form deps acceptance (16 tests).
- Variants: variant_resolver listing + label parsing + invalid
variant errors + parent-key normalization + free-form passthrough
(13 tests).
- Curated/hybrid: daily_mix rank-to-genre resolution + rank-out-of-
range empty + invalid-variant error; fresh_tape & archives
hydration order + missing-id skip + source-specific-then-fallback
key dispatch + limit + missing-database-dep error; seasonal_mix
curated-id hydration order + missing-id skip + JSON round-trip +
empty-curated empty + limit + missing-service error (21 tests).
3304+ tests pass. No regression on existing 62 personalized tests.
37 lines
1.4 KiB
Python
37 lines
1.4 KiB
Python
"""Shared helpers for personalized-playlist generators.
|
|
|
|
Each per-kind generator module is small + mechanical — it pulls the
|
|
legacy ``PersonalizedPlaylistsService`` instance off the deps object
|
|
and calls the matching method, then coerces results. This module
|
|
holds the bits every generator reuses so we don't repeat them
|
|
five times."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import Any, List
|
|
|
|
from core.personalized.types import Track
|
|
|
|
|
|
def get_service(deps: Any):
|
|
"""Pull the ``PersonalizedPlaylistsService`` instance from deps.
|
|
|
|
Generators access the service via ``deps.service``. Tests can
|
|
pass a fake deps namespace with a ``service`` attribute that
|
|
returns a stub. Raises a clear error if the dep isn't wired."""
|
|
service = getattr(deps, 'service', None) or (deps.get('service') if isinstance(deps, dict) else None)
|
|
if service is None:
|
|
raise RuntimeError(
|
|
"Personalized generator deps missing `service` "
|
|
"(PersonalizedPlaylistsService instance). Wire it during "
|
|
"PersonalizedPlaylistManager construction."
|
|
)
|
|
return service
|
|
|
|
|
|
def coerce_tracks(rows: List[dict]) -> List[Track]:
|
|
"""Convert legacy generator output (list of dicts) into Track
|
|
instances. Tolerates None / non-list inputs by returning []."""
|
|
if not rows:
|
|
return []
|
|
return [Track.from_dict(row) for row in rows if isinstance(row, dict)]
|