00b26fc5f1
When a track matches a SINGLE release it carries the single's name/id and the canonical grouping files it apart from its album-mates -> mixed cover art (Sokhi). This re-homes it onto the album that actually contains it. The selection is a pure, CONSERVATIVE function and the lookup loop takes injected fetchers, so both are unit-testable without a live client. It only re-homes a track when a real 'album'-type release's tracklist contains that EXACT track (qualifier-tolerant) — never promotes a genuine standalone single, never guesses (a wrong promotion would mis-home a real single, the inverse bug). Fail-safe: any miss/error -> None (track stays as matched). 13 seam tests. Wiring next.
134 lines
4.6 KiB
Python
134 lines
4.6 KiB
Python
"""Seam tests for single -> parent-album resolution (Sokhi: single-matched track
|
|
splits from its album -> mixed cover art). The selector is pure; the resolver
|
|
takes injected fetchers, so neither needs a live metadata client.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from core.imports.single_to_album import (
|
|
select_parent_album,
|
|
resolve_single_to_album,
|
|
)
|
|
|
|
|
|
# ── pure selector ─────────────────────────────────────────────────────────────
|
|
def _alb(name, tracks, album_type="album", **extra):
|
|
return {"name": name, "album_type": album_type, "tracks": tracks, **extra}
|
|
|
|
|
|
def test_picks_album_that_contains_the_track():
|
|
got = select_parent_album("Yellow", [
|
|
_alb("Parachutes", ["Don't Panic", "Shiver", "Yellow", "Trouble"]),
|
|
])
|
|
assert got and got["name"] == "Parachutes"
|
|
|
|
|
|
def test_returns_none_when_no_album_contains_the_track():
|
|
assert select_parent_album("Yellow", [
|
|
_alb("Some Other Album", ["Track A", "Track B"]),
|
|
]) is None
|
|
|
|
|
|
def test_never_promotes_onto_a_single_release():
|
|
# The single's own release (album_type 'single', name == track) must be ignored.
|
|
assert select_parent_album("Yellow", [
|
|
_alb("Yellow", ["Yellow"], album_type="single"),
|
|
]) is None
|
|
|
|
|
|
def test_ignores_ep_and_compilation_types():
|
|
assert select_parent_album("Yellow", [
|
|
_alb("Yellow EP", ["Yellow", "Yellow (Live)"], album_type="ep"),
|
|
_alb("Greatest Hits", ["Yellow", "Clocks"], album_type="compilation"),
|
|
]) is None
|
|
|
|
|
|
def test_skips_album_named_exactly_like_the_track():
|
|
# An 'album' whose name IS the track title is the single dressed as an album;
|
|
# don't treat it as the parent.
|
|
assert select_parent_album("Yellow", [
|
|
_alb("Yellow", ["Yellow"]),
|
|
]) is None
|
|
|
|
|
|
def test_matches_through_album_version_qualifier():
|
|
got = select_parent_album("Yellow", [
|
|
_alb("Parachutes", ["Shiver", "Yellow (Album Version)"]),
|
|
])
|
|
assert got and got["name"] == "Parachutes"
|
|
|
|
|
|
def test_first_qualifying_candidate_wins_deterministically():
|
|
got = select_parent_album("Yellow", [
|
|
_alb("Parachutes", ["Yellow"]),
|
|
_alb("Parachutes (Deluxe)", ["Yellow", "Bonus"]),
|
|
])
|
|
assert got["name"] == "Parachutes" # input order = priority
|
|
|
|
|
|
def test_empty_title_returns_none():
|
|
assert select_parent_album("", [_alb("Parachutes", ["Yellow"])]) is None
|
|
|
|
|
|
# ── injected-I/O resolver ─────────────────────────────────────────────────────
|
|
def test_resolver_finds_parent_album_lazily():
|
|
calls = {"tracks": 0}
|
|
albums = [
|
|
{"name": "Single Yellow", "album_type": "single", "id": "s1"}, # skipped (not album)
|
|
{"name": "Wrong Album", "album_type": "album", "id": "a1"},
|
|
{"name": "Parachutes", "album_type": "album", "id": "a2"},
|
|
]
|
|
|
|
def fetch_tracks(alb):
|
|
calls["tracks"] += 1
|
|
return {"a1": ["Other"], "a2": ["Yellow", "Shiver"]}.get(alb["id"], [])
|
|
|
|
got = resolve_single_to_album(
|
|
"Yellow",
|
|
fetch_album_candidates=lambda: albums,
|
|
fetch_album_tracks=fetch_tracks,
|
|
)
|
|
assert got and got["name"] == "Parachutes" and got["album_id"] == "a2"
|
|
assert calls["tracks"] == 2 # probed a1 then a2, stopped; never probed the single
|
|
|
|
|
|
def test_resolver_returns_none_when_nothing_contains_track():
|
|
got = resolve_single_to_album(
|
|
"Yellow",
|
|
fetch_album_candidates=lambda: [{"name": "X", "album_type": "album", "id": "a1"}],
|
|
fetch_album_tracks=lambda alb: ["Nope"],
|
|
)
|
|
assert got is None
|
|
|
|
|
|
def test_resolver_is_failsafe_on_candidate_fetch_error():
|
|
def boom():
|
|
raise RuntimeError("api down")
|
|
assert resolve_single_to_album(
|
|
"Yellow", fetch_album_candidates=boom, fetch_album_tracks=lambda a: []) is None
|
|
|
|
|
|
def test_resolver_is_failsafe_on_track_fetch_error():
|
|
def boom(alb):
|
|
raise RuntimeError("api down")
|
|
got = resolve_single_to_album(
|
|
"Yellow",
|
|
fetch_album_candidates=lambda: [{"name": "Parachutes", "album_type": "album", "id": "a1"}],
|
|
fetch_album_tracks=boom)
|
|
assert got is None
|
|
|
|
|
|
def test_resolver_caps_albums_probed():
|
|
albums = [{"name": f"A{i}", "album_type": "album", "id": str(i)} for i in range(20)]
|
|
probed = {"n": 0}
|
|
|
|
def fetch_tracks(alb):
|
|
probed["n"] += 1
|
|
return ["nope"]
|
|
|
|
resolve_single_to_album(
|
|
"Yellow",
|
|
fetch_album_candidates=lambda: albums,
|
|
fetch_album_tracks=fetch_tracks,
|
|
max_albums=5)
|
|
assert probed["n"] == 5 # never probes more than the cap
|