53284ee7c8
Adds the per-kind generator modules and registers them with the
PlaylistKindRegistry so the manager's `refresh_playlist` can dispatch
to any of them.
Generators (each in its own module under
`core/personalized/generators/`):
Singletons (variant=''):
- hidden_gems -> wraps service.get_hidden_gems
- discovery_shuffle -> wraps service.get_discovery_shuffle
- popular_picks -> wraps service.get_popular_picks
Variant-bearing kinds:
- time_machine -> variant = decade label ('1980s', '1990s', ...).
Variant resolver returns 7 standard decades.
Generator parses '1980s' -> 1980 + delegates
to service.get_decade_playlist.
- genre_playlist -> variant = URL-safe genre key
('electronic_dance', 'hip_hop_rap', ...).
Resolver normalizes parent-genre keys from
service.GENRE_MAPPING; free-form keywords
pass through to service.get_genre_playlist.
- daily_mix -> variant = top-genre rank ('1' / '2' / '3' / '4').
Generator looks up user's Nth-ranked library
genre and returns discovery picks within it.
Library half (was a stub returning []) is
intentionally dropped: tracks table has no
source IDs, so library rows can't sync. Fixed
the stub to return [] cleanly without the
misleading log warning.
- fresh_tape -> Spotify Release Radar. Reads curated track
IDs from discovery_curated_playlists (tries
'release_radar_<source>' first, falls back to
'release_radar') and hydrates against the
discovery pool.
- archives -> Spotify Discover Weekly. Same hydration path
as fresh_tape but uses 'discovery_weekly'.
- seasonal_mix -> variant = season key ('halloween' / 'christmas'
/ 'valentines' / 'summer' / 'spring' / 'autumn').
Reads curated IDs via SeasonalDiscoveryService
then hydrates from seasonal_tracks (which
carries full track_data_json).
Each module:
- Defines `generate(deps, variant, config) -> List[Track]`.
- Defines `SPEC = PlaylistKindSpec(...)` and registers it on import
(idempotent — re-import safe via `if registry.get(...) is None`).
- For variant-bearing kinds, also defines `variant_resolver(deps)`.
Shared helpers in `_common.py`:
- `get_service(deps)` pulls the legacy
`PersonalizedPlaylistsService` instance (deps.service or
deps['service']).
- `coerce_tracks(rows)` runs each dict through `Track.from_dict`,
tolerates None / non-list inputs.
Tests (50 new, total 85 across personalized subsystem):
- Singletons: registration + display name + dispatch + limit
forwarding + empty/None tolerance + missing-deps error +
dict-form deps acceptance (16 tests).
- Variants: variant_resolver listing + label parsing + invalid
variant errors + parent-key normalization + free-form passthrough
(13 tests).
- Curated/hybrid: daily_mix rank-to-genre resolution + rank-out-of-
range empty + invalid-variant error; fresh_tape & archives
hydration order + missing-id skip + source-specific-then-fallback
key dispatch + limit + missing-database-dep error; seasonal_mix
curated-id hydration order + missing-id skip + JSON round-trip +
empty-curated empty + limit + missing-service error (21 tests).
3304+ tests pass. No regression on existing 62 personalized tests.
131 lines
4.8 KiB
Python
131 lines
4.8 KiB
Python
"""Boundary tests for variant-bearing personalized generators
|
|
(`time_machine` per decade, `genre_playlist` per genre).
|
|
|
|
Each generator coerces a URL-safe variant string into the form the
|
|
legacy service expects, then forwards. Tests pin the variant
|
|
parsing + service dispatch + variant_resolver listing."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from types import SimpleNamespace
|
|
from typing import List
|
|
|
|
import pytest
|
|
|
|
from core.personalized.generators import genre_playlist as _gp_mod
|
|
from core.personalized.generators import time_machine as _tm_mod
|
|
from core.personalized.specs import get_registry
|
|
from core.personalized.types import PlaylistConfig
|
|
|
|
|
|
class _StubService:
|
|
GENRE_MAPPING = {
|
|
'Electronic/Dance': ['house', 'techno'],
|
|
'Hip Hop/Rap': ['hip hop', 'rap'],
|
|
'Rock': ['rock', 'punk'],
|
|
}
|
|
|
|
def __init__(self):
|
|
self.calls: List[dict] = []
|
|
|
|
def get_decade_playlist(self, decade, limit, **kw):
|
|
self.calls.append({'method': 'get_decade_playlist', 'decade': decade, 'limit': limit})
|
|
return [{'track_name': f'D{decade}', 'artist_name': 'A'}]
|
|
|
|
def get_genre_playlist(self, genre, limit, **kw):
|
|
self.calls.append({'method': 'get_genre_playlist', 'genre': genre, 'limit': limit})
|
|
return [{'track_name': f'G{genre}', 'artist_name': 'A'}]
|
|
|
|
|
|
def _deps():
|
|
return SimpleNamespace(service=_StubService())
|
|
|
|
|
|
# ─── time_machine ───────────────────────────────────────────────────
|
|
|
|
|
|
class TestTimeMachine:
|
|
def test_registered(self):
|
|
spec = get_registry().get('time_machine')
|
|
assert spec is not None
|
|
assert spec.requires_variant is True
|
|
assert spec.variant_resolver is not None
|
|
|
|
def test_variant_resolver_returns_decades(self):
|
|
spec = get_registry().get('time_machine')
|
|
decades = spec.variant_resolver(_deps())
|
|
assert '1980s' in decades
|
|
assert '2020s' in decades
|
|
# All decades should be 4-digit + 's'
|
|
for d in decades:
|
|
assert d.endswith('s')
|
|
assert d[:-1].isdigit()
|
|
|
|
def test_decade_label_to_year(self):
|
|
deps = _deps()
|
|
_tm_mod.generate(deps, '1980s', PlaylistConfig(limit=20))
|
|
assert deps.service.calls == [
|
|
{'method': 'get_decade_playlist', 'decade': 1980, 'limit': 20}
|
|
]
|
|
|
|
def test_invalid_variant_raises(self):
|
|
deps = _deps()
|
|
with pytest.raises(ValueError, match='not a decade label'):
|
|
_tm_mod.generate(deps, 'banana', PlaylistConfig())
|
|
|
|
def test_out_of_range_year_raises(self):
|
|
deps = _deps()
|
|
with pytest.raises(ValueError, match='out of range'):
|
|
_tm_mod.generate(deps, '1500s', PlaylistConfig())
|
|
|
|
def test_tolerates_no_s_suffix(self):
|
|
deps = _deps()
|
|
_tm_mod.generate(deps, '1990', PlaylistConfig())
|
|
assert deps.service.calls[0]['decade'] == 1990
|
|
|
|
def test_default_limit_is_100(self):
|
|
spec = get_registry().get('time_machine')
|
|
assert spec.default_config.limit == 100
|
|
|
|
def test_display_name_with_variant(self):
|
|
spec = get_registry().get('time_machine')
|
|
assert spec.display_name('1980s') == 'Time Machine — 1980s'
|
|
|
|
|
|
# ─── genre_playlist ─────────────────────────────────────────────────
|
|
|
|
|
|
class TestGenrePlaylist:
|
|
def test_registered(self):
|
|
spec = get_registry().get('genre_playlist')
|
|
assert spec is not None
|
|
assert spec.requires_variant is True
|
|
|
|
def test_variant_resolver_normalizes_parent_keys(self):
|
|
spec = get_registry().get('genre_playlist')
|
|
variants = spec.variant_resolver(_deps())
|
|
# 'Electronic/Dance' → 'electronic_dance' (slash → underscore + lowercase)
|
|
assert 'electronic_dance' in variants
|
|
assert 'hip_hop_rap' in variants
|
|
assert 'rock' in variants
|
|
|
|
def test_normalized_variant_resolves_to_parent_key(self):
|
|
deps = _deps()
|
|
_gp_mod.generate(deps, 'electronic_dance', PlaylistConfig())
|
|
# Service receives ORIGINAL parent key.
|
|
assert deps.service.calls[0]['genre'] == 'Electronic/Dance'
|
|
|
|
def test_unknown_variant_passed_through_as_freeform(self):
|
|
# Service handles partial-matching for free-form keywords.
|
|
deps = _deps()
|
|
_gp_mod.generate(deps, 'shoegaze', PlaylistConfig())
|
|
assert deps.service.calls[0]['genre'] == 'shoegaze'
|
|
|
|
def test_empty_variant_raises(self):
|
|
deps = _deps()
|
|
with pytest.raises(ValueError, match='requires a variant'):
|
|
_gp_mod.generate(deps, '', PlaylistConfig())
|
|
|
|
def test_display_name(self):
|
|
spec = get_registry().get('genre_playlist')
|
|
assert spec.display_name('electronic_dance') == 'Genre — electronic_dance'
|