1ad80d77a6
The mirror_playlist fix only assigns stable ids to newly-imported playlists, so a user with an existing file-import playlist would still have empty-id rows (and dead Find & Add matches) until a manual re-import. Add an idempotent startup backfill that assigns the SAME stable id a fresh import would to any mirrored track missing one — so existing matches start sticking with no re-import. Runs once per db/process (the init is guarded), only touches empty-id rows (no-op afterward), native ids untouched. Tests: backfill fills empty ids with the exact fresh-import id, is idempotent (2nd run = 0), and leaves native ids alone.
127 lines
5.4 KiB
Python
127 lines
5.4 KiB
Python
from database.music_database import MusicDatabase
|
|
|
|
|
|
def test_update_mirrored_playlist_source_ref_preserves_tracks(tmp_path):
|
|
db = MusicDatabase(str(tmp_path / "music.db"))
|
|
playlist_id = db.mirror_playlist(
|
|
source="youtube",
|
|
source_playlist_id="oldhash",
|
|
name="Mirror",
|
|
tracks=[
|
|
{
|
|
"track_name": "Song",
|
|
"artist_name": "Artist",
|
|
"source_track_id": "yt1",
|
|
"extra_data": {"discovered": True},
|
|
}
|
|
],
|
|
profile_id=1,
|
|
description="https://youtube.com/playlist?list=old",
|
|
)
|
|
|
|
assert playlist_id is not None
|
|
|
|
updated = db.update_mirrored_playlist_source_ref(
|
|
playlist_id,
|
|
"newhash",
|
|
"https://youtube.com/playlist?list=new",
|
|
)
|
|
|
|
assert updated is True
|
|
playlist = db.get_mirrored_playlist(playlist_id)
|
|
assert playlist["source_playlist_id"] == "newhash"
|
|
assert playlist["description"] == "https://youtube.com/playlist?list=new"
|
|
|
|
tracks = db.get_mirrored_playlist_tracks(playlist_id)
|
|
assert len(tracks) == 1
|
|
assert tracks[0]["track_name"] == "Song"
|
|
assert tracks[0]["extra_data"] is not None
|
|
|
|
|
|
def test_mirror_playlist_refresh_preserves_existing_description(tmp_path):
|
|
db = MusicDatabase(str(tmp_path / "music.db"))
|
|
playlist_id = db.mirror_playlist(
|
|
source="spotify_public",
|
|
source_playlist_id="hash",
|
|
name="Release Radar",
|
|
tracks=[{"track_name": "Song", "artist_name": "Artist"}],
|
|
profile_id=1,
|
|
description="https://open.spotify.com/playlist/abc",
|
|
)
|
|
|
|
refreshed_id = db.mirror_playlist(
|
|
source="spotify_public",
|
|
source_playlist_id="hash",
|
|
name="Release Radar",
|
|
tracks=[{"track_name": "New Song", "artist_name": "Artist"}],
|
|
profile_id=1,
|
|
)
|
|
|
|
assert refreshed_id == playlist_id
|
|
playlist = db.get_mirrored_playlist(playlist_id)
|
|
assert playlist["description"] == "https://open.spotify.com/playlist/abc"
|
|
|
|
|
|
def test_file_import_tracks_get_a_stable_source_track_id(tmp_path):
|
|
# #901: file-import tracks arrive with no source_track_id; mirror_playlist must
|
|
# assign a deterministic one so a Find & Add manual match can key on it (and so
|
|
# discovery extra_data survives a re-import).
|
|
db = MusicDatabase(str(tmp_path / "music.db"))
|
|
file_tracks = [
|
|
{"track_name": "Slow Ride", "artist_name": "Foghat", "album_name": "Fool for the City"},
|
|
{"track_name": "I Gotta Feeling", "artist_name": "The Black Eyed Peas"},
|
|
]
|
|
pid = db.mirror_playlist(source="file", source_playlist_id="myfile", name="From File",
|
|
tracks=file_tracks, profile_id=1)
|
|
rows = db.get_mirrored_playlist_tracks(pid)
|
|
ids = [r["source_track_id"] for r in rows]
|
|
assert all(i and i.startswith("file:") for i in ids) # no empty ids
|
|
assert len(set(ids)) == 2 # distinct per song
|
|
|
|
# Re-import the SAME file → SAME ids (stable), so a recorded match still keys.
|
|
db.mirror_playlist(source="file", source_playlist_id="myfile", name="From File",
|
|
tracks=list(file_tracks), profile_id=1)
|
|
rows2 = db.get_mirrored_playlist_tracks(pid)
|
|
assert [r["source_track_id"] for r in rows2] == ids
|
|
|
|
|
|
def test_native_ids_still_used_verbatim(tmp_path):
|
|
db = MusicDatabase(str(tmp_path / "music.db"))
|
|
pid = db.mirror_playlist(source="spotify", source_playlist_id="sp", name="Sp",
|
|
tracks=[{"track_name": "S", "artist_name": "A", "source_track_id": "spotify123"}],
|
|
profile_id=1)
|
|
rows = db.get_mirrored_playlist_tracks(pid)
|
|
assert rows[0]["source_track_id"] == "spotify123" # native id untouched
|
|
|
|
|
|
def test_backfill_fills_existing_empty_ids_idempotently(tmp_path):
|
|
# #901 backfill: a file-import playlist mirrored BEFORE the fix has empty-id rows.
|
|
# The backfill assigns the SAME stable ids a fresh import would, so existing
|
|
# Find & Add matches start working without a re-import.
|
|
db = MusicDatabase(str(tmp_path / "music.db"))
|
|
pid = db.mirror_playlist(source="file", source_playlist_id="old", name="Old",
|
|
tracks=[{"track_name": "Slow Ride", "artist_name": "Foghat"}], profile_id=1)
|
|
# simulate a pre-fix row: blank out the id
|
|
with db._get_connection() as conn:
|
|
conn.execute("UPDATE mirrored_playlist_tracks SET source_track_id = '' WHERE playlist_id = ?", (pid,))
|
|
conn.commit()
|
|
|
|
n = db._backfill_mirrored_track_source_ids()
|
|
assert n == 1
|
|
rows = db.get_mirrored_playlist_tracks(pid)
|
|
from core.playlists.source_refs import stable_source_track_id
|
|
assert rows[0]["source_track_id"] == stable_source_track_id(
|
|
{"track_name": "Slow Ride", "artist_name": "Foghat"}) # same id a fresh import gives
|
|
|
|
# idempotent — second run touches nothing
|
|
assert db._backfill_mirrored_track_source_ids() == 0
|
|
|
|
|
|
def test_backfill_leaves_native_ids_untouched(tmp_path):
|
|
db = MusicDatabase(str(tmp_path / "music.db"))
|
|
pid = db.mirror_playlist(source="spotify", source_playlist_id="sp", name="Sp",
|
|
tracks=[{"track_name": "S", "artist_name": "A", "source_track_id": "spotify123"}],
|
|
profile_id=1)
|
|
db._backfill_mirrored_track_source_ids()
|
|
rows = db.get_mirrored_playlist_tracks(pid)
|
|
assert rows[0]["source_track_id"] == "spotify123"
|