Commit graph

2 commits

Author SHA1 Message Date
Broque Thomas
8b0de9eb76 fix(downloads): harden album bundle staging
Route torrent and Usenet album bundles through private per-batch staging so Auto-Import cannot race public staging or duplicate imports.

Expose album-bundle progress in batch status and render it on the Downloads page while the external client is still downloading.

Tighten release handoff safety by rejecting archive path traversal, ignoring torrent candidates without a usable URL, and skipping Soulseek source reuse for torrent/Usenet batches.

Tests: .venv/bin/python -m pytest tests/downloads/test_downloads_status.py tests/test_album_bundle_dispatch.py tests/downloads/test_downloads_staging.py tests/test_torrent_usenet_plugins.py
2026-05-20 21:39:06 -07:00
Broque Thomas
5f126584f9 feat(downloads): add archive_pipeline module for torrent/usenet downloads
Shared helper the upcoming torrent and usenet download plugins
both compose against. Narrow surface — no matching, no tagging,
no library import. Just walks audio files and extracts archives
when needed.

Why a separate module: usenet downloaders (SABnzbd, NZBGet)
already auto-extract by default, and Lidarr's import pipeline
extracts before SoulSync sees the files. The only client that
sometimes leaves an archive behind is a torrent client when the
album was packed as a .rar — most music torrents ship loose but
not all. Centralising the walk + extract logic means both new
plugins can do the same thing, and a future direct-archive source
(zip download from a private site, etc.) plugs in for free.

- core/archive_pipeline.py:
  - AUDIO_EXTENSIONS / ARCHIVE_EXTENSIONS constants (audio set
    matches core/imports/file_ops.py quality_tiers).
  - is_archive(path) handles compound extensions (.tar.gz etc).
  - walk_audio_files(directory) — recursive, case-insensitive.
  - find_archives_in_dir(directory) — top-level only (don't
    surprise-extract sample / proof folders inside a torrent).
  - extract_archive(archive_path, extract_to=None) — handles
    .zip, .tar variants, .rar (optional rarfile dep), .7z
    (optional py7zr dep). Optional deps warn-and-skip if absent.
  - extract_all_in_dir + collect_audio_after_extraction — the
    one-shot helpers the download plugins call after a download
    completes.
  - Path-traversal protection: every archive member's resolved
    path must stay inside the destination — first violator aborts
    the extract without writing anything. Applies to zip, tar,
    and rar.
- tests/test_archive_pipeline.py: 21 tests covering the walker
  (nested dirs, case-insensitive, ignores non-audio), archive
  detection (compound extensions, missing files), zip extraction
  + path-traversal rejection, tar.gz + tar path-traversal,
  multi-archive directory, mixed-loose-and-archived collection.
2026-05-20 17:05:00 -07:00