danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Fix discovery progress not updating in modal (ListenBrainz, YouTube, etc.)

Browse source 
Discovery status polling was skipped when WebSocket was connected
(8 places), assuming socket events would push updates. But no
WebSocket events exist for discovery progress — the table stayed
on "Pending..." forever. Now always polls the status endpoint.
Pre-existing bug, not caused by recent changes.
This commit is contained in:
Broque Thomas 2026-04-01 16:45:51 -07:00
parent 119840fa5d
commit f58be8f05c
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
webui/static/script.js
View file

@ -15109,7 +15109,7 @@ function startSyncPolling(playlistId) {
// Start a new poller that checks every 2 seconds
console.log(`🔄 Starting sync polling for playlist: ${playlistId}`);
activeSyncPollers[playlistId] = setInterval(async () => {
if (socketConnected) return; // Phase 5: WS handles updates
// Always poll — no dedicated WebSocket events for discovery progress
try {
console.log(`📊 Polling sync status for: ${playlistId}`);
const response = await fetch(`/api/sync/status/${playlistId}`);
@ -24049,7 +24049,7 @@ function startTidalDiscoveryPolling(fakeUrlHash, playlistId) {
}
const pollInterval = setInterval(async () => {
if (socketConnected) return; // Phase 5: WS handles updates
// Always poll — no dedicated WebSocket events for discovery progress
try {
const response = await fetch(`/api/tidal/discovery/status/${playlistId}`);
const status = await response.json();
@ -26851,7 +26851,7 @@ function startBeatportDiscoveryPolling(urlHash) {
}
const pollInterval = setInterval(async () => {
if (socketConnected) return; // Phase 5: WS handles updates
// Always poll — no dedicated WebSocket events for discovery progress
try {
const response = await fetch(`/api/beatport/discovery/status/${urlHash}`);
const status = await response.json();
@ -30231,7 +30231,7 @@ function startYouTubeDiscoveryPolling(urlHash) {
}
const pollInterval = setInterval(async () => {
if (socketConnected) return; // Phase 5: WS handles updates
// Always poll — no dedicated WebSocket events for discovery progress
try {
const response = await fetch(`/api/youtube/discovery/status/${urlHash}`);
const status = await response.json();
@ -31678,7 +31678,7 @@ function startListenBrainzDiscoveryPolling(playlistMbid) {
}
const pollInterval = setInterval(async () => {
if (socketConnected) return; // Phase 5: WS handles updates
// Always poll — no dedicated WebSocket events for discovery progress
try {
const response = await fetch(`/api/listenbrainz/discovery/status/${playlistMbid}`);
const status = await response.json();
@ -51143,7 +51143,7 @@ function startDecadeSyncPolling(decade, virtualPlaylistId) {
}
discoverSyncPollers[pollerId] = setInterval(async () => {
if (socketConnected) return; // Phase 5: WS handles updates
// Always poll — no dedicated WebSocket events for discovery progress
try {
const response = await fetch(`/api/sync/status/${virtualPlaylistId}`);
if (!response.ok) return;
@ -51544,7 +51544,7 @@ function startGenreSyncPolling(genreName, genreId, virtualPlaylistId) {
}
discoverSyncPollers[pollerId] = setInterval(async () => {
if (socketConnected) return; // Phase 5: WS handles updates
// Always poll — no dedicated WebSocket events for discovery progress
try {
const response = await fetch(`/api/sync/status/${virtualPlaylistId}`);
if (!response.ok) return;
@ -54003,7 +54003,7 @@ function startDiscoverSyncPolling(playlistType, virtualPlaylistId) {
// Poll every 500ms for progress updates
discoverSyncPollers[playlistType] = setInterval(async () => {
if (socketConnected) return; // Phase 5: WS handles updates
// Always poll — no dedicated WebSocket events for discovery progress
try {
const response = await fetch(`/api/sync/status/${virtualPlaylistId}`);
if (!response.ok) {