danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(quality-upgrade): pass config_manager to path resolver so relative DB paths resolve

Browse source 
resolve_library_file_path() was called without config_manager, so
_collect_base_dirs() returned an empty list and every track stored
with a relative path (Artist/Album/track.flac) resolved to None.
probe_audio_quality was never called → 0 files checked.

Also threads resolved_path through _read_file_ids to avoid a second
redundant resolution pass on the same file.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
dev 2026-06-24 15:16:42 +02:00
parent bdbeff89d6
commit e4ba27d8b3
1 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
core/repair_jobs/quality_upgrade.py
View file

@ -178,14 +178,14 @@ def _norm_isrc(value: Any) -> str:
return str(value).upper().replace('-', '').replace(' ', '').strip() return str(value).upper().replace('-', '').replace(' ', '').strip()
def _read_file_ids(file_path: str) -> Dict[str, str]: def _read_file_ids(file_path: str, resolved_path: Optional[str] = None) -> Dict[str, str]:
"""Read the identifiers enrichment embedded in the file's tags. """Read the identifiers enrichment embedded in the file's tags.
Enrichment matches every track to the metadata sources and writes the IDs Enrichment matches every track to the metadata sources and writes the IDs
(ISRC + per-source track IDs) into the file — so an already-enriched track (ISRC + per-source track IDs) into the file — so an already-enriched track
carries its exact identity. Returns a dict with a normalized ``isrc`` plus any carries its exact identity. Returns a dict with a normalized ``isrc`` plus any
``<source>_track_id`` tags present; empty dict when unreadable / not enriched.""" ``<source>_track_id`` tags present; empty dict when unreadable / not enriched."""
resolved = resolve_library_file_path(file_path) if file_path else None resolved = resolved_path or (resolve_library_file_path(file_path) if file_path else None)
if not resolved and file_path and os.path.isfile(file_path): if not resolved and file_path and os.path.isfile(file_path):
resolved = file_path resolved = file_path
if not resolved: if not resolved:
@ -618,8 +618,13 @@ class QualityUpgradeJob(RepairJob):
continue continue
# v3 quality decision — probe the REAL file. Resolve the library path # v3 quality decision — probe the REAL file. Resolve the library path
# first (the DB stores a possibly-relative path). # first (the DB stores a possibly-relative path). Pass config_manager so
resolved_path = resolve_library_file_path(file_path) if file_path else None # the resolver can find the transfer/music folders and expand relative paths.
resolved_path = resolve_library_file_path(
file_path,
transfer_folder=context.transfer_folder,
config_manager=context.config_manager,
) if file_path else None
if not resolved_path and file_path and os.path.isfile(file_path): if not resolved_path and file_path and os.path.isfile(file_path):
resolved_path = file_path resolved_path = file_path
@ -673,7 +678,8 @@ class QualityUpgradeJob(RepairJob):
# Read the identifiers enrichment embedded in the file once (ISRC + # Read the identifiers enrichment embedded in the file once (ISRC +
# per-source track IDs), used by the two most-exact tiers below. # per-source track IDs), used by the two most-exact tiers below.
file_ids = _read_file_ids(file_path) # Pass resolved_path so the inner resolver doesn't redo the lookup.
file_ids = _read_file_ids(file_path, resolved_path=resolved_path)
# Tiered match, best identity first, loosest last: # Tiered match, best identity first, loosest last:
# 0. The active source's OWN track ID, embedded in the file by # 0. The active source's OWN track ID, embedded in the file by