danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix 'Replace lower quality on import' setting not persisting

Browse source 
The import section appeared twice in the saveSettings object literal —
the second key (staging_path only) silently overwrote the first
(replace_lower_quality). JavaScript uses last-wins for duplicate keys.
Merged into a single import block.
This commit is contained in:
Broque Thomas 2026-04-15 20:03:38 -07:00
parent 41b5cd1f34
commit e1cda4eb59
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
webui/static/helper.js
View file

@ -3607,6 +3607,7 @@ const WHATS_NEW = {
{ title: 'Fix Wishlist Button on Non-Dashboard Pages', desc: 'Wishlist button click handler moved to global init so it works from any page, not just the dashboard' }, { title: 'Fix Wishlist Button on Non-Dashboard Pages', desc: 'Wishlist button click handler moved to global init so it works from any page, not just the dashboard' },
{ title: 'Fix Allow Duplicates Setting Not Saving', desc: 'The "Allow duplicate tracks across albums" toggle was never persisted — it silently reset to ON on every page reload. Now saves correctly' }, { title: 'Fix Allow Duplicates Setting Not Saving', desc: 'The "Allow duplicate tracks across albums" toggle was never persisted — it silently reset to ON on every page reload. Now saves correctly' },
{ title: 'Fix Wishlist Dropping Cross-Album Tracks', desc: 'Wishlist cleanup was removing same-titled tracks from different albums even when Allow Duplicates was enabled. Cleanup now respects the setting — same song from different albums can coexist in the wishlist' }, { title: 'Fix Wishlist Dropping Cross-Album Tracks', desc: 'Wishlist cleanup was removing same-titled tracks from different albums even when Allow Duplicates was enabled. Cleanup now respects the setting — same song from different albums can coexist in the wishlist' },
{ title: 'Fix "Replace Lower Quality" Setting Not Persisting', desc: 'The import section appeared twice in the settings save payload — the second instance (with only staging_path) overwrote the first (with replace_lower_quality). Merged into a single block' },
// --- April 14, 2026 --- // --- April 14, 2026 ---
{ date: 'April 14, 2026' }, { date: 'April 14, 2026' },

6
webui/static/script.js
View file

@ -7286,7 +7286,8 @@ async function saveSettings(quiet = false) {
music_videos_path: document.getElementById('music-videos-path').value || './MusicVideos' music_videos_path: document.getElementById('music-videos-path').value || './MusicVideos'
}, },
import: { import: {
replace_lower_quality: document.getElementById('import-replace-lower-quality').checked replace_lower_quality: document.getElementById('import-replace-lower-quality').checked,
staging_path: document.getElementById('staging-path').value || './Staging'
}, },
lossy_copy: { lossy_copy: {
enabled: document.getElementById('lossy-copy-enabled').checked, enabled: document.getElementById('lossy-copy-enabled').checked,
@ -7299,9 +7300,6 @@ async function saveSettings(quiet = false) {
enabled: document.getElementById('listening-stats-enabled').checked, enabled: document.getElementById('listening-stats-enabled').checked,
poll_interval: parseInt(document.getElementById('listening-stats-interval').value) || 30, poll_interval: parseInt(document.getElementById('listening-stats-interval').value) || 30,
}, },
import: {
staging_path: document.getElementById('staging-path').value || './Staging'
},
m3u_export: { m3u_export: {
enabled: document.getElementById('m3u-export-enabled').checked, enabled: document.getElementById('m3u-export-enabled').checked,
entry_base_path: document.getElementById('m3u-entry-base-path').value || '' entry_base_path: document.getElementById('m3u-entry-base-path').value || ''