danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Cover Art Filler: log WHY albums are skipped (Sokhi — stop guessing the cover.jpg cause)

Browse source 
Sokhi's scans keep returning 0 findings and we've been guessing at the cause
across several fixes. Add a skip-reason breakdown + per-album decision dump so
the next scan log shows it definitively instead:

- [cover-diag] per-album (first 5): album, raw DB path, resolved path,
  has_local, embedded, sidecar, db_missing, cover_enabled, needs_fix.
- [cover-diag] skip breakdown in the summary: have_disk_art /
  no_local_db_has_art (path didn't resolve, DB has thumb) / no_art_source.

Leading hypothesis this will confirm: the file paths aren't resolving
(resolved=None → has_local=False), so the scan only ever looks at db_missing —
which flipped every album from flagged (before the DB-art fix populated thumbs)
to skipped (after). If so the real fix is path resolution, not the art logic.
No behavior change — logging only.
This commit is contained in:
BoulderBadgeDad 2026-06-08 17:21:07 -07:00
parent a4a2135c19
commit d9a1fdb81f
1 changed files with 33 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
core/repair_jobs/missing_cover_art.py
View file

@ -140,6 +140,15 @@ class MissingCoverArtJob(RepairJob):
logger.info("Found %d albums missing cover art", total)
download_folder = (context.config_manager.get('soulseek.download_path', '')
if context.config_manager else None)
# Skip-reason breakdown so a "0 findings" scan tells us WHY each album
# was skipped instead of guessing (Sokhi cover.jpg saga). Logged in the
# summary line below.
skip_reasons = {
'have_disk_art': 0, # local file has embedded art + sidecar (or sidecar not wanted)
'no_local_db_has_art': 0, # file path didn't resolve; DB already has a thumb
'no_art_source': 0, # needs fix, but no API art found and nothing embedded to extract
}
_diag_logged = 0
if context.report_progress:
context.report_progress(phase=f'Searching artwork for {total} albums...', total=total)
@ -205,7 +214,23 @@ class MissingCoverArtJob(RepairJob):
embed_missing = db_missing
sidecar_from_embedded = False
needs_fix = db_missing
# Diagnostic: dump the decision inputs for the first few albums so a
# confusing "0 findings" scan reveals path-resolution + on-disk state
# (Sokhi: scans kept returning 0 with no way to see why).
if _diag_logged < 5:
logger.info(
"[cover-diag] album=%r db_path=%r resolved=%r local=%s embedded=%s "
"sidecar=%s db_missing=%s cover_enabled=%s needs_fix=%s",
title, rep_path, resolved_rep, has_local, has_embedded, has_sidecar,
db_missing, cover_sidecar_enabled, needs_fix)
_diag_logged += 1
if not needs_fix:
if not has_local:
skip_reasons['no_local_db_has_art'] += 1
else:
skip_reasons['have_disk_art'] += 1
result.skipped += 1
continue
@ -303,6 +328,7 @@ class MissingCoverArtJob(RepairJob):
logger.debug("Error creating cover art finding for album %s: %s", album_id, e)
result.errors += 1
else:
skip_reasons['no_art_source'] += 1
result.skipped += 1
if context.update_progress and (i + 1) % 5 == 0:
@ -313,6 +339,13 @@ class MissingCoverArtJob(RepairJob):
logger.info("Cover art scan: %d albums checked, %d found art, %d skipped",
result.scanned, result.findings_created, result.skipped)
if result.skipped:
logger.info(
"[cover-diag] skip breakdown — have_disk_art=%d (already have embedded+sidecar), "
"no_local_db_has_art=%d (file path didn't resolve, DB has thumb), "
"no_art_source=%d (needed art but none found/embedded)",
skip_reasons['have_disk_art'], skip_reasons['no_local_db_has_art'],
skip_reasons['no_art_source'])
return result
def _try_source(self, source, source_album_id, title, artist_name):