danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #448 from Nezreka/fix/test-fixture-real-db-write-prevention

Browse source 
Stop config retry tests from writing to the real DB
This commit is contained in:
BoulderBadgeDad 2026-04-30 14:09:48 -07:00 committed by GitHub
commit b62182a3f5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 17 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
tests/test_config_save_retry.py
View file

@ -24,14 +24,29 @@ from config.settings import ConfigManager
@pytest.fixture
def manager(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> ConfigManager:
"""Build a ConfigManager rooted at a tmp dir so every test starts clean."""
"""Build a ConfigManager rooted at a tmp dir so every test starts clean.
CRITICAL: ConfigManager reads ``DATABASE_PATH`` (not ``SOULSYNC_DB_PATH``)
when picking the DB location. Setting the wrong env var here would let
tests reach the real ``database/music_library.db`` and clobber the
user's encrypted credentials. The ``database_path`` is also pinned
directly on the instance after construction as a defense-in-depth check
in case ConfigManager's resolution logic ever changes.
"""
config_path = tmp_path / "config.json"
db_path = tmp_path / "database" / "music_library.db"
monkeypatch.setenv("SOULSYNC_CONFIG_PATH", str(config_path))
monkeypatch.setenv("SOULSYNC_DB_PATH", str(db_path))
monkeypatch.setenv("DATABASE_PATH", str(db_path))
mgr = ConfigManager(str(config_path))
# Defense-in-depth: pin the path on the instance so even if ConfigManager
# ignored the env var, the DB writes still land in the tmp directory.
mgr.database_path = db_path
mgr.config_path = config_path
# Replace whatever was loaded with a known payload so we can assert on it
mgr.config_data = {"plex": {"base_url": "http://example.test"}}
assert str(mgr.database_path).startswith(str(tmp_path)), (
"Test fixture would write to a non-tmp DB — refusing to run"
)
return mgr