danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix get_artist_albums cache not actually storing data

Browse source 
The cache stores raw_data through _extract_fields which expects a dict
with a 'name' field. Storing a raw list caused silent AttributeError,
and storing a dict without 'name' triggered junk entity rejection
(empty string is in _JUNK_NAMES). Now wraps the albums list in a dict
with a valid name field so it passes validation and persists correctly.
This commit is contained in:
Broque Thomas 2026-03-31 22:05:01 -07:00
parent 54f927320d
commit b5c2878533
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
core/spotify_client.py
View file

@ -1318,7 +1318,8 @@ class SpotifyClient:
cached = cache.get_entity(source, 'artist', cache_key)
if cached:
try:
return [Album.from_spotify_album(ad) for ad in cached]
albums_list = cached.get('_albums', cached) if isinstance(cached, dict) else cached
return [Album.from_spotify_album(ad) for ad in albums_list]
except Exception:
pass # Cache data incompatible, re-fetch
@ -1339,9 +1340,9 @@ class SpotifyClient:
logger.info(f"Retrieved {len(albums)} albums for artist {artist_id}")
# Cache the full artist albums result
# Cache the full artist albums result (wrapped in dict for cache compatibility)
if raw_items:
cache.store_entity('spotify', 'artist', cache_key, raw_items)
cache.store_entity('spotify', 'artist', cache_key, {'name': f'albums_{artist_id}', '_albums': raw_items})
# Also cache individual albums opportunistically
entries = [(ad.get('id'), ad) for ad in raw_items if ad.get('id')]
if entries: