danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

#852 tests: cover the login-mode WS gate (the reported bypass was the login modal)

Browse source 
The integration test only exercised the launch-PIN path; the actual #852 report is
the "Sign in to SoulSync" username/password modal. Add login-mode cases: socketio
connect is rejected when require_login is on + unauthenticated, allowed once
login_authenticated. Confirms the WS gate covers both overlays.
This commit is contained in:
BoulderBadgeDad 2026-06-11 17:38:24 -07:00
parent 31ebe96f76
commit b5b9d6e5f4
1 changed files with 23 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
tests/test_ws_connect_gate.py
View file

@ -82,3 +82,26 @@ def test_socket_allowed_when_pin_verified(monkeypatch):
s['launch_pin_verified'] = True
sio = web_server.socketio.test_client(web_server.app, flask_test_client=flask_client)
assert sio.is_connected() is True
# ── login mode (the "Sign in to SoulSync" path — #852 report was this one) ──
def _login_on(monkeypatch):
real = web_server.config_manager.get
monkeypatch.setattr(web_server.config_manager, 'get',
lambda k, d=None: True if k == 'security.require_login' else real(k, d))
def test_socket_rejected_when_login_required_and_unauthenticated(monkeypatch):
_login_on(monkeypatch)
flask_client = web_server.app.test_client() # no login_authenticated
sio = web_server.socketio.test_client(web_server.app, flask_test_client=flask_client)
assert sio.is_connected() is False # login overlay can't be bypassed via WS
def test_socket_allowed_when_login_authenticated(monkeypatch):
_login_on(monkeypatch)
flask_client = web_server.app.test_client()
with flask_client.session_transaction() as s:
s['login_authenticated'] = True
sio = web_server.socketio.test_client(web_server.app, flask_test_client=flask_client)
assert sio.is_connected() is True