danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix allow_duplicates for same-track-ID across different albums

Browse source 
The wishlist table has a UNIQUE constraint on spotify_track_id, so
INSERT OR REPLACE silently overwrote the existing entry when the same
track appeared on a different album (same Spotify track ID). Now uses
a composite key (track_id::album_id) when allow_duplicates is on and
the base track ID already exists, allowing both versions to coexist.
Only affects users with allow_duplicates enabled.
This commit is contained in:
Broque Thomas 2026-04-12 19:37:13 -07:00
parent 3a7c25f20f
commit b4cf8b4cc1
1 changed files with 23 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
database/music_database.py
View file

@ -6486,12 +6486,33 @@ class MusicDatabase:
spotify_json = json.dumps(spotify_track_data)
source_json = json.dumps(source_info or {})
# No duplicate found, insert the track
# When allow_duplicates is on, make the key unique per album so the same
# track from different albums can coexist in the wishlist
insert_track_id = track_id
if allow_duplicates:
album_obj = spotify_track_data.get('album', {})
album_id = album_obj.get('id', '') if isinstance(album_obj, dict) else ''
if album_id:
# Check if this exact track+album combo already exists
composite_id = f"{track_id}::{album_id}"
cursor.execute("SELECT id FROM wishlist_tracks WHERE spotify_track_id = ? AND profile_id = ?",
(composite_id, profile_id))
if cursor.fetchone():
logger.debug(f"Skipping wishlist entry — same track+album already in wishlist: '{track_name}' on '{album_obj.get('name', '')}'")
return False
# Check if base track_id exists (from a different album)
cursor.execute("SELECT id FROM wishlist_tracks WHERE spotify_track_id = ? AND profile_id = ?",
(track_id, profile_id))
if cursor.fetchone():
# Same track exists from different album — use composite ID
insert_track_id = composite_id
# Insert the track
cursor.execute("""
INSERT OR REPLACE INTO wishlist_tracks
(spotify_track_id, spotify_data, failure_reason, source_type, source_info, date_added, profile_id)
VALUES (?, ?, ?, ?, ?, CURRENT_TIMESTAMP, ?)
""", (track_id, spotify_json, failure_reason, source_type, source_json, profile_id))
""", (insert_track_id, spotify_json, failure_reason, source_type, source_json, profile_id))
conn.commit()