danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix discover hero/modal to strictly filter similar artists by active source

Browse source
This commit is contained in:
Broque Thomas 2026-03-14 10:20:25 -07:00
parent 719980cf5a
commit a512d6ae70
1 changed files with 7 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
web_server.py
View file

@ -30063,8 +30063,9 @@ def get_discover_hero():
itunes_client = iTunesClient() itunes_client = iTunesClient()
# Get top similar artists (excluding watchlist, cycled by last_featured) # Get top similar artists (excluding watchlist, cycled by last_featured)
# Fetch more than needed since strict source filtering may drop many
pid = get_current_profile_id() pid = get_current_profile_id()
similar_artists = database.get_top_similar_artists(limit=50, profile_id=pid) similar_artists = database.get_top_similar_artists(limit=200, profile_id=pid)
# FALLBACK: If no similar artists exist, use watchlist artists for Hero section # FALLBACK: If no similar artists exist, use watchlist artists for Hero section
if not similar_artists: if not similar_artists:
@ -30112,9 +30113,6 @@ def get_discover_hero():
valid_artists.append(artist) valid_artists.append(artist)
elif active_source == 'itunes' and artist.similar_artist_itunes_id: elif active_source == 'itunes' and artist.similar_artist_itunes_id:
valid_artists.append(artist) valid_artists.append(artist)
# If we have both IDs, include regardless of source
elif artist.similar_artist_spotify_id and artist.similar_artist_itunes_id:
valid_artists.append(artist)
# FALLBACK: If no valid artists for iTunes, try to resolve iTunes IDs on-the-fly # FALLBACK: If no valid artists for iTunes, try to resolve iTunes IDs on-the-fly
if active_source == 'itunes' and not valid_artists: if active_source == 'itunes' and not valid_artists:
@ -30228,21 +30226,18 @@ def get_discover_similar_artists():
if not similar_artists: if not similar_artists:
return jsonify({"success": True, "artists": [], "source": active_source, "count": 0}) return jsonify({"success": True, "artists": [], "source": active_source, "count": 0})
# Filter to artists with valid ID for active source # Filter to artists with valid ID for active source (strict — no cross-source)
result_artists = [] result_artists = []
for artist in similar_artists: for artist in similar_artists:
has_spotify = bool(artist.similar_artist_spotify_id) if active_source == 'spotify' and not artist.similar_artist_spotify_id:
has_itunes = bool(artist.similar_artist_itunes_id)
if active_source == 'spotify' and not has_spotify and not has_itunes:
continue continue
if active_source == 'itunes' and not has_itunes and not has_spotify: if active_source == 'itunes' and not artist.similar_artist_itunes_id:
continue continue
if active_source == 'spotify': if active_source == 'spotify':
artist_id = artist.similar_artist_spotify_id or artist.similar_artist_itunes_id artist_id = artist.similar_artist_spotify_id
else: else:
artist_id = artist.similar_artist_itunes_id or artist.similar_artist_spotify_id artist_id = artist.similar_artist_itunes_id
artist_data = { artist_data = {
"artist_id": artist_id, "artist_id": artist_id,