danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix Album Completeness job scanning no albums due to wrong HAVING filter

Browse source 
The SQL HAVING clause filtered on local track count instead of expected
track count, excluding albums with fewer than 3 local tracks from the
scan entirely. Now fetches all Spotify-matched albums and filters by
expected track count in the loop.
This commit is contained in:
Broque Thomas 2026-03-19 08:36:15 -07:00
parent 99481a0232
commit 8754e160b0
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
core/repair_jobs/album_completeness.py
View file

@ -36,7 +36,7 @@ class AlbumCompletenessJob(RepairJob):
settings = self._get_settings(context)
min_tracks = settings.get('min_tracks_for_check', 3)
# Fetch albums with spotify_album_id that have enough tracks to check
# Fetch all albums with a spotify_album_id — filter by expected track count in the loop
albums = []
conn = None
try:
@ -50,8 +50,7 @@ class AlbumCompletenessJob(RepairJob):
LEFT JOIN tracks t ON t.album_id = al.id
WHERE al.spotify_album_id IS NOT NULL AND al.spotify_album_id != ''
GROUP BY al.id
HAVING actual_count >= ?
""", (min_tracks,))
""")
albums = cursor.fetchall()
except Exception as e:
logger.error("Error fetching albums: %s", e, exc_info=True)
@ -98,6 +97,13 @@ class AlbumCompletenessJob(RepairJob):
except Exception:
pass
# Skip singles/EPs based on expected track count (not local count)
if expected_total and expected_total < min_tracks:
result.skipped += 1
if context.update_progress and (i + 1) % 5 == 0:
context.update_progress(i + 1, total)
continue
if not expected_total or actual_count >= expected_total:
result.skipped += 1
if context.update_progress and (i + 1) % 5 == 0: