From 7e70bbaaed4d55e5e0ca87a63938fd55980506ff Mon Sep 17 00:00:00 2001 From: Broque Thomas <26755000+Nezreka@users.noreply.github.com> Date: Tue, 12 May 2026 14:14:19 -0700 Subject: [PATCH] Repair worker: log debug instead of bare pass on active-server lookup Ruff S110 (try-except-pass) on the lookup inside `_build_unresolvable_album_folder_error`. Swallowed exception is benign (some test stubs don't expose `get_active_media_server` and we fall back to 'unknown'), but ruff is right that bare pass is a smell. Logger is the existing repair_worker logger, so this matches the same "debug-log on optional-input failure" pattern used in `core/library/path_resolver.py:_collect_base_dirs`. --- core/repair_worker.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/repair_worker.py b/core/repair_worker.py index 6804ac07..2c0b07f8 100644 --- a/core/repair_worker.py +++ b/core/repair_worker.py @@ -1949,8 +1949,8 @@ class RepairWorker: active_server = getter() or 'unknown' else: active_server = self._config_manager.get('active_media_server', 'unknown') or 'unknown' - except Exception: - pass + except Exception as e: + logger.debug("active media server lookup failed: %s", e) lines = [ "Could not find any existing track from this album on disk.",