danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix Download Discography button on library artist page

Browse source 
The button called openDiscographyModal() which expected discography
data in artistsPageState — but the library page never populated it.
Now fetches discography on-demand from /api/artist/<id>/discography
when called from the library page, using the artist's DB ID and name.
This commit is contained in:
Broque Thomas 2026-04-01 15:57:26 -07:00
parent ce9ba42a91
commit 77e4671236
1 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
webui/static/script.js
View file

@ -40949,7 +40949,7 @@ function applyDiscographyFilters() {
// ==================== Download Discography Modal ==================== // ==================== Download Discography Modal ====================
function openDiscographyModal() { async function openDiscographyModal() {
// Support both Artists search page and Library artist detail page // Support both Artists search page and Library artist detail page
let artist = artistsPageState.selectedArtist; let artist = artistsPageState.selectedArtist;
let discography = artistsPageState.artistDiscography; let discography = artistsPageState.artistDiscography;
@ -40961,13 +40961,28 @@ function openDiscographyModal() {
const libName = artistDetailPageState.currentArtistName; const libName = artistDetailPageState.currentArtistName;
if (libId && libName) { if (libId && libName) {
artist = { id: libId, name: libName, image_url: document.getElementById('artist-detail-image')?.src || '' }; artist = { id: libId, name: libName, image_url: document.getElementById('artist-detail-image')?.src || '' };
// Library page stores discography in the same artistsPageState when viewing from library
discography = artistsPageState.artistDiscography; discography = artistsPageState.artistDiscography;
// If discography not loaded, fetch it on-demand
if (!discography) {
try {
showToast('Loading discography...', 'info');
const res = await fetch(`/api/artist/${libId}/discography?artist_name=${encodeURIComponent(libName)}`);
const data = await res.json();
if (data && (data.albums || data.eps || data.singles)) {
discography = data;
artistsPageState.artistDiscography = data;
artistsPageState.selectedArtist = artist;
}
} catch (e) {
console.error('Failed to load discography:', e);
}
}
} }
} }
if (!artist || !discography) { if (!artist || !discography) {
showToast('No discography data available', 'error'); showToast('No discography data available. Artist may not be on Spotify/iTunes.', 'error');
return; return;
} }