danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix playlist mode downloads getting no metadata or cover art

Browse source 
Playlist folder mode passed album_info=None to _enhance_file_metadata,
which crashed on the first .get() call. The try/except caught it and
called _wipe_source_tags, stripping ALL metadata from the file.

Now normalizes None album_info to empty dict at the top of the function,
and adds a cover art fallback that pulls the image URL from the
spotify_album context when album_info doesn't have one.
This commit is contained in:
Broque Thomas 2026-04-20 13:54:01 -07:00
parent 2249aa7594
commit 741712ce6e
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
web_server.py
View file

@ -18733,6 +18733,10 @@ def _enhance_file_metadata(file_path: str, context: dict, artist: dict, album_in
print("Metadata enhancement disabled in config.")
return True
# Normalize None album_info to empty dict to prevent AttributeError on .get() calls
if album_info is None:
album_info = {}
# Acquire per-file lock to prevent concurrent metadata writes to the same file
file_lock = _get_file_lock(file_path)
with file_lock:
@ -19081,7 +19085,16 @@ def _extract_spotify_metadata(context: dict, artist: dict, album_info: dict) ->
if _genre_list:
metadata['genre'] = ', '.join(_genre_list)
metadata['album_art_url'] = album_info.get('album_image_url')
metadata['album_art_url'] = album_info.get('album_image_url') if album_info else None
# Playlist mode fallback: album_info is None, try to get art from spotify_album context
if not metadata['album_art_url']:
_spa = context.get('spotify_album', {})
if _spa:
_spa_img = _spa.get('image_url')
if not _spa_img and _spa.get('images'):
_spa_img = _spa['images'][0].get('url') if isinstance(_spa['images'][0], dict) else None
metadata['album_art_url'] = _spa_img
# Extract source IDs (Spotify or iTunes) for tag embedding
track_info = context.get("track_info", {})