-
- `;
- } else {
- // Lazy load images for similar artists that don't have them
- lazyLoadSimilarArtistImages(container);
- }
- }
- } catch (parseError) {
- console.error('❌ Error parsing stream message:', parseError);
- }
- }
- }
-
- // Clear the controller when done
- similarArtistsController = null;
-
- } catch (error) {
- // Don't show error if it was aborted (user navigated away)
- if (error.name === 'AbortError') {
- console.log('⏹️ Similar artists stream aborted (user navigated to new artist)');
- loadingEl.classList.add('hidden');
- return;
- }
-
- console.error('❌ Error loading similar artists:', error);
-
- // Hide loading, show error
- loadingEl.classList.add('hidden');
- errorEl.classList.remove('hidden');
-
- // Also show error message in container
- container.innerHTML = `
- 🎵
- No similar artists found
-
-
- `;
- } finally {
- // Always clear the controller
- similarArtistsController = null;
- }
-}
-
-/**
- * Lazy load images for similar artist bubbles that don't have images
- */
-async function lazyLoadSimilarArtistImages(container) {
- if (!container) return;
-
- const bubblesNeedingImages = container.querySelectorAll('.similar-artist-bubble[data-needs-image="true"]');
-
- if (bubblesNeedingImages.length === 0) {
- console.log('✅ All similar artist bubbles have images');
- return;
- }
-
- console.log(`🖼️ Lazy loading images for ${bubblesNeedingImages.length} similar artists`);
-
- // Load images in parallel batches
- const batchSize = 5;
- const bubbles = Array.from(bubblesNeedingImages);
-
- for (let i = 0; i < bubbles.length; i += batchSize) {
- const batch = bubbles.slice(i, i + batchSize);
-
- await Promise.all(batch.map(async (bubble) => {
- const artistId = bubble.getAttribute('data-artist-id');
- const artistSource = bubble.getAttribute('data-artist-source') || '';
- const artistPlugin = bubble.getAttribute('data-artist-plugin') || '';
- if (!artistId) return;
-
- try {
- const params = new URLSearchParams();
- if (artistSource) params.set('source', artistSource);
- if (artistPlugin) params.set('plugin', artistPlugin);
-
- const imageUrl = params.toString()
- ? `/api/artist/${encodeURIComponent(artistId)}/image?${params.toString()}`
- : `/api/artist/${encodeURIComponent(artistId)}/image`;
-
- const response = await fetch(imageUrl);
- const data = await response.json();
-
- if (data.success && data.image_url) {
- const imageContainer = bubble.querySelector('.similar-artist-bubble-image');
- if (imageContainer) {
- const artistName = bubble.querySelector('.similar-artist-bubble-name')?.textContent || 'Artist';
- imageContainer.innerHTML = `⚠️
- ${error.message}
- 🎵
`;
- bubble.setAttribute('data-needs-image', 'true');
- };
-
- imageContainer.appendChild(img);
- } else {
- // No image - show fallback (will be lazy loaded)
- imageContainer.innerHTML = `🎵
`;
- }
-
- // Create name element
- const name = document.createElement('div');
- name.className = 'similar-artist-bubble-name';
- name.textContent = artist.name;
- name.title = artist.name; // Tooltip for full name
-
- // Optional: Create genres element (hidden by default in CSS)
- const genres = document.createElement('div');
- genres.className = 'similar-artist-bubble-genres';
- if (artist.genres && artist.genres.length > 0) {
- genres.textContent = artist.genres.slice(0, 2).join(', ');
- }
-
- // Assemble bubble
- bubble.appendChild(imageContainer);
- bubble.appendChild(name);
- if (artist.genres && artist.genres.length > 0) {
- bubble.appendChild(genres);
- }
-
- // Add click handler to navigate to artist detail page
- bubble.addEventListener('click', () => {
- console.log(`🎵 Clicked similar artist: ${artist.name} (ID: ${artist.id})`);
- // Navigate to this artist's detail page (same as clicking from search results)
- selectArtistForDetail(
- artist,
- artist.source ? { source: artist.source, plugin: artist.plugin } : {}
- );
- });
-
- return bubble;
-}
/**
* Restore cached completion data without re-scanning the database
diff --git a/webui/static/library.js b/webui/static/library.js
index 33e58955..147d52b1 100644
--- a/webui/static/library.js
+++ b/webui/static/library.js
@@ -949,6 +949,11 @@ function populateArtistDetailPage(data) {
console.log(`📀 EPs:`, discography.eps);
console.log(`📀 Singles:`, discography.singles);
+ // Tag the body so CSS can hide library-only UI for source artists (e.g.
+ // the Enhanced view toggle, the Status filter, completion bars). Set
+ // BEFORE rendering so any layout-dependent code sees the right state.
+ document.body.dataset.artistSource = (artist && artist.server_source) ? 'library' : 'source';
+
// Update hero section with image, name, and stats
updateArtistHeroSection(artist, discography);
@@ -966,6 +971,13 @@ function populateArtistDetailPage(data) {
if (libraryWatchlistBtn && data.spotify_artist && data.spotify_artist.spotify_artist_id) {
initializeLibraryWatchlistButton(data.spotify_artist.spotify_artist_id, data.spotify_artist.spotify_artist_name);
}
+
+ // Load Similar Artists section (works for both library + source artists via
+ // MusicMap name lookup). Fire-and-forget — the function handles its own
+ // loading state and errors.
+ if (artist && artist.name && typeof loadSimilarArtists === 'function') {
+ loadSimilarArtists(artist.name);
+ }
}
function updateArtistDetailImage(imageUrl, artistName) {
diff --git a/webui/static/shared-helpers.js b/webui/static/shared-helpers.js
index d45737f5..d2da2042 100644
--- a/webui/static/shared-helpers.js
+++ b/webui/static/shared-helpers.js
@@ -2759,3 +2759,366 @@ function renderEnrichmentCards(enrichment) {
}
// ===============================
+
+
+// ----------------------------------------------------------------------------
+// Similar Artists — fetch + render via MusicMap. Source-agnostic (artist name
+// based), works for both library and metadata-source artists. Targets DOM IDs
+// #similar-artists-loading, #similar-artists-error, #similar-artists-bubbles-
+// container that live on the artist-detail page.
+// ----------------------------------------------------------------------------
+
+// Similar artists lives on two pages (the inline Artists page and the standalone
+// artist-detail page), each with its own set of IDs so they don't collide in the
+// DOM. This resolver picks the set whose `.page` ancestor is currently active.
+function _resolveSimilarArtistsTargets() {
+ const candidates = [
+ // standalone artist-detail page (scoped ids)
+ { section: 'ad-similar-artists-section', loading: 'ad-similar-artists-loading', error: 'ad-similar-artists-error', bubbles: 'ad-similar-artists-bubbles-container' },
+ // legacy inline Artists page (base ids)
+ { section: 'similar-artists-section', loading: 'similar-artists-loading', error: 'similar-artists-error', bubbles: 'similar-artists-bubbles-container' },
+ ];
+ // Prefer the set whose parent .page is currently active.
+ for (const c of candidates) {
+ const el = document.getElementById(c.section);
+ if (el && el.closest('.page.active')) {
+ return {
+ section: el,
+ loadingEl: document.getElementById(c.loading),
+ errorEl: document.getElementById(c.error),
+ container: document.getElementById(c.bubbles),
+ };
+ }
+ }
+ // Fallback: return the first set that exists at all.
+ for (const c of candidates) {
+ const el = document.getElementById(c.section);
+ if (el) {
+ return {
+ section: el,
+ loadingEl: document.getElementById(c.loading),
+ errorEl: document.getElementById(c.error),
+ container: document.getElementById(c.bubbles),
+ };
+ }
+ }
+ return null;
+}
+
+async function loadSimilarArtists(artistName) {
+ if (!artistName) {
+ console.warn('⚠️ No artist name provided for similar artists');
+ return;
+ }
+
+ console.log(`🔍 Loading similar artists for: ${artistName}`);
+
+ const targets = _resolveSimilarArtistsTargets();
+ if (!targets) {
+ console.warn('⚠️ Similar artists section elements not found on any active page');
+ return;
+ }
+ const { section, loadingEl, errorEl, container } = targets;
+
+ // Show loading state
+ loadingEl.classList.remove('hidden');
+ errorEl.classList.add('hidden');
+ container.innerHTML = '';
+ section.style.display = 'block';
+
+ try {
+ // Create new abort controller for this similar artists stream
+ similarArtistsController = new AbortController();
+
+ // Use streaming endpoint for real-time bubble creation
+ const url = `/api/artist/similar/${encodeURIComponent(artistName)}/stream`;
+ console.log(`📡 Streaming from: ${url}`);
+
+ const response = await fetch(url, {
+ signal: similarArtistsController.signal
+ });
+
+ if (!response.ok) {
+ throw new Error(`Failed to fetch similar artists: ${response.status}`);
+ }
+
+ const reader = response.body.getReader();
+ const decoder = new TextDecoder();
+ let buffer = '';
+ let artistCount = 0;
+
+ // Read the stream
+ while (true) {
+ const { done, value } = await reader.read();
+
+ if (done) {
+ console.log('✅ Stream complete');
+ break;
+ }
+
+ // Decode the chunk and add to buffer
+ buffer += decoder.decode(value, { stream: true });
+
+ // Process complete messages (separated by \n\n)
+ const messages = buffer.split('\n\n');
+ buffer = messages.pop() || ''; // Keep incomplete message in buffer
+
+ for (const message of messages) {
+ if (!message.trim() || !message.startsWith('data: ')) continue;
+
+ try {
+ const jsonData = JSON.parse(message.substring(6)); // Remove 'data: ' prefix
+
+ if (jsonData.error) {
+ throw new Error(jsonData.error);
+ }
+
+ if (jsonData.artist) {
+ // Hide loading on first artist
+ if (artistCount === 0) {
+ loadingEl.classList.add('hidden');
+ }
+
+ // Create and append bubble immediately
+ const bubble = createSimilarArtistBubble(jsonData.artist);
+ container.appendChild(bubble);
+ artistCount++;
+
+ console.log(`✅ Added bubble for: ${jsonData.artist.name} (${artistCount})`);
+ }
+
+ if (jsonData.complete) {
+ console.log(`🎉 Streaming complete: ${jsonData.total} artists`);
+
+ if (artistCount === 0) {
+ loadingEl.classList.add('hidden');
+ container.innerHTML = `
+
+
+ `;
+ } else {
+ // Lazy load images for similar artists that don't have them
+ lazyLoadSimilarArtistImages(container);
+ }
+ }
+ } catch (parseError) {
+ console.error('❌ Error parsing stream message:', parseError);
+ }
+ }
+ }
+
+ // Clear the controller when done
+ similarArtistsController = null;
+
+ } catch (error) {
+ // Don't show error if it was aborted (user navigated away)
+ if (error.name === 'AbortError') {
+ console.log('⏹️ Similar artists stream aborted (user navigated to new artist)');
+ loadingEl.classList.add('hidden');
+ return;
+ }
+
+ console.error('❌ Error loading similar artists:', error);
+
+ // Hide loading, show error
+ loadingEl.classList.add('hidden');
+ errorEl.classList.remove('hidden');
+
+ // Also show error message in container
+ container.innerHTML = `
+ 🎵
+ No similar artists found
+
+
+ `;
+ } finally {
+ // Always clear the controller
+ similarArtistsController = null;
+ }
+}
+
+/**
+ * Lazy load images for similar artist bubbles that don't have images
+ */
+async function lazyLoadSimilarArtistImages(container) {
+ if (!container) return;
+
+ const bubblesNeedingImages = container.querySelectorAll('.similar-artist-bubble[data-needs-image="true"]');
+
+ if (bubblesNeedingImages.length === 0) {
+ console.log('✅ All similar artist bubbles have images');
+ return;
+ }
+
+ console.log(`🖼️ Lazy loading images for ${bubblesNeedingImages.length} similar artists`);
+
+ // Load images in parallel batches
+ const batchSize = 5;
+ const bubbles = Array.from(bubblesNeedingImages);
+
+ for (let i = 0; i < bubbles.length; i += batchSize) {
+ const batch = bubbles.slice(i, i + batchSize);
+
+ await Promise.all(batch.map(async (bubble) => {
+ const artistId = bubble.getAttribute('data-artist-id');
+ const artistSource = bubble.getAttribute('data-artist-source') || '';
+ const artistPlugin = bubble.getAttribute('data-artist-plugin') || '';
+ if (!artistId) return;
+
+ try {
+ const params = new URLSearchParams();
+ if (artistSource) params.set('source', artistSource);
+ if (artistPlugin) params.set('plugin', artistPlugin);
+
+ const imageUrl = params.toString()
+ ? `/api/artist/${encodeURIComponent(artistId)}/image?${params.toString()}`
+ : `/api/artist/${encodeURIComponent(artistId)}/image`;
+
+ const response = await fetch(imageUrl);
+ const data = await response.json();
+
+ if (data.success && data.image_url) {
+ const imageContainer = bubble.querySelector('.similar-artist-bubble-image');
+ if (imageContainer) {
+ const artistName = bubble.querySelector('.similar-artist-bubble-name')?.textContent || 'Artist';
+ imageContainer.innerHTML = `⚠️
+ ${error.message}
+ 🎵
`;
+ bubble.setAttribute('data-needs-image', 'true');
+ };
+
+ imageContainer.appendChild(img);
+ } else {
+ // No image - show fallback (will be lazy loaded)
+ imageContainer.innerHTML = `🎵
`;
+ }
+
+ // Create name element
+ const name = document.createElement('div');
+ name.className = 'similar-artist-bubble-name';
+ name.textContent = artist.name;
+ name.title = artist.name; // Tooltip for full name
+
+ // Optional: Create genres element (hidden by default in CSS)
+ const genres = document.createElement('div');
+ genres.className = 'similar-artist-bubble-genres';
+ if (artist.genres && artist.genres.length > 0) {
+ genres.textContent = artist.genres.slice(0, 2).join(', ');
+ }
+
+ // Assemble bubble
+ bubble.appendChild(imageContainer);
+ bubble.appendChild(name);
+ if (artist.genres && artist.genres.length > 0) {
+ bubble.appendChild(genres);
+ }
+
+ // Add click handler to navigate to artist detail page
+ bubble.addEventListener('click', () => {
+ console.log(`🎵 Clicked similar artist: ${artist.name} (ID: ${artist.id})`);
+ // Navigate to this artist's detail page (same as clicking from search results)
+ selectArtistForDetail(
+ artist,
+ artist.source ? { source: artist.source, plugin: artist.plugin } : {}
+ );
+ });
+
+ return bubble;
+}
diff --git a/webui/static/style.css b/webui/static/style.css
index 7298bc44..6600bcec 100644
--- a/webui/static/style.css
+++ b/webui/static/style.css
@@ -59377,3 +59377,39 @@ body.reduce-effects *::after {
font-size: 18px;
}
}
+
+
+/* =========================================================================
+ Source-artist visibility rules
+ =========================================================================
+ When the artist-detail page is rendering a source artist (Spotify / Deezer /
+ iTunes / etc. — not in the local library), hide library-only UI. The body
+ data-artist-source attribute is set by library.js populateArtistDetailPage
+ before rendering.
+*/
+
+/* Library-only: status filter (owned/missing only makes sense when you own things) */
+body[data-artist-source="source"] #artist-detail-page .filter-group:has(.filter-label:only-child),
+body[data-artist-source="source"] #artist-detail-page .discography-filter-btn[data-filter="ownership"] {
+ display: none !important;
+}
+
+/* Library-only: Enhanced view toggle + container (per-track editing requires owned tracks) */
+body[data-artist-source="source"] #artist-detail-page .enhanced-view-toggle-btn,
+body[data-artist-source="source"] #artist-detail-page #enhanced-view-container {
+ display: none !important;
+}
+
+/* Library-only: completion bars, enrichment coverage, Top Tracks sidebar, Radio / Enhance Quality buttons */
+body[data-artist-source="source"] #artist-detail-page .collection-overview,
+body[data-artist-source="source"] #artist-detail-page .artist-enrichment-coverage,
+body[data-artist-source="source"] #artist-detail-page #artist-hero-sidebar,
+body[data-artist-source="source"] #artist-detail-page #library-artist-radio-btn,
+body[data-artist-source="source"] #artist-detail-page #library-artist-enhance-btn {
+ display: none !important;
+}
+
+/* Library-only: section-stats "0 owned / 0 missing" counts don't apply */
+body[data-artist-source="source"] #artist-detail-page .section-stats {
+ display: none !important;
+}