danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

#863: YT Artist column falls back to the matched artist when YouTube gave none (both render paths) — no more 'Unknown Artist' on matched rows

Browse source
This commit is contained in:
BoulderBadgeDad 2026-06-13 00:06:41 -07:00
parent 0577dc92e5
commit 6366f72b7e
1 changed files with 21 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
webui/static/sync-services.js
View file

@ -10048,7 +10048,14 @@ function generateTableRowsFromState(state, urlHash) {
return discoveryResults.map((result, index) => { return discoveryResults.map((result, index) => {
// Handle different field names based on platform // Handle different field names based on platform
const trackName = result.lb_track || result.yt_track || result.track_name || '-'; const trackName = result.lb_track || result.yt_track || result.track_name || '-';
const artistName = result.lb_artist || result.yt_artist || result.artist_name || '-'; // YouTube flat extraction often can't give a per-track artist, so the
// source-side artist comes back "Unknown Artist" even when discovery
// matched the song. Fall back to the matched (Spotify/iTunes) artist so
// the column shows the real artist instead of "Unknown" (#863).
let artistName = result.lb_artist || result.yt_artist || result.artist_name || '';
if (!artistName || artistName === 'Unknown Artist') {
artistName = result.spotify_artist || artistName || '-';
}
return ` return `
<tr id="discovery-row-${urlHash}-${result.index}"> <tr id="discovery-row-${urlHash}-${result.index}">
@ -10191,6 +10198,19 @@ function updateYouTubeDiscoveryModal(urlHash, status) {
statusCell.textContent = result.status; statusCell.textContent = result.status;
statusCell.className = `discovery-status ${result.status_class}`; statusCell.className = `discovery-status ${result.status_class}`;
// Fill the source-side artist live too — YouTube flat extraction often
// leaves it "Unknown Artist", so fall back to the matched artist once
// discovery resolves the track (#863). Without this, the per-row poll
// updates only the Spotify cells and the left column stays "Unknown".
const ytArtistCell = row.querySelector('.yt-artist');
if (ytArtistCell) {
let ytArtist = result.yt_artist || result.artist_name || '';
if (!ytArtist || ytArtist === 'Unknown Artist') {
ytArtist = result.spotify_artist || ytArtist || '-';
}
ytArtistCell.textContent = ytArtist;
}
spotifyTrackCell.textContent = result.spotify_track || '-'; spotifyTrackCell.textContent = result.spotify_track || '-';
spotifyArtistCell.textContent = result.spotify_artist || '-'; spotifyArtistCell.textContent = result.spotify_artist || '-';
spotifyAlbumCell.textContent = result.spotify_album || '-'; spotifyAlbumCell.textContent = result.spotify_album || '-';