danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Fix downloads nav badge dropping to 300 after page open

Browse source 
_adlFetch() fetches /api/downloads/all?limit=300 then _adlUpdateBadge()
was counting active statuses from that truncated array, overwriting
the real server-side count maintained by WebSocket. Removed the
badge update from _adlFetch — the WebSocket status push already
keeps it accurate.
This commit is contained in:
Broque Thomas 2026-04-19 17:28:08 -07:00
parent dd3b71bc9a
commit 5fb1972361
3 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
web_server.py
View file

@ -22529,6 +22529,7 @@ def get_version_info():
"• Reject Qobuz 30-second sample/preview downloads",
"• Fix library page crash on All filter — non-string soul_id broke card rendering",
"• Auto Wing It fallback for failed discovery — unmatched tracks download via Soulseek with raw metadata",
"• Fix downloads badge dropping to 300 after opening Downloads page",
"• Fix server playlist Find & Add inserting at wrong position on Plex",
"• Smarter Fix modal results — standard album versions sorted above live/remix/cover/soundtrack variants",
"• Unmatch discovery tracks — red ✕ button to remove bad matches from playlist discovery",

1
webui/static/helper.js
View file

@ -3602,6 +3602,7 @@ const WHATS_NEW = {
'2.33': [
// --- April 19, 2026 ---
{ date: 'April 19, 2026' },
{ title: 'Fix Downloads Badge Dropping to 300', desc: 'Downloads nav badge showed the correct count from WebSocket but dropped to max 300 after opening the Downloads page because it recounted from a truncated local array. Badge now stays accurate from the server-side count' },
{ title: 'Fix Server Playlist Find & Add Position', desc: 'When using "Find & add" on server playlists with Plex, the track was always appended to the end instead of inserted at the correct position. Now moves the track to the right slot after adding' },
{ title: 'Smarter Fix Modal Search Results', desc: 'The discovery Fix modal now sorts search results to prioritize standard album versions over live recordings, remixes, covers, soundtracks, remasters, and deluxe editions. Previously the first result was often a live or remix version instead of the original studio track' },
{ title: 'Unmatch Discovery Tracks', desc: 'Found tracks in playlist discovery now have a red ✕ button to remove the match. Sets the track back to Not Found so it won\'t be downloaded. For mirrored playlists, the unmatch persists in the DB and is respected on re-discovery runs' },

4
webui/static/script.js
View file

@ -76172,7 +76172,9 @@ async function _adlFetch() {
_adlBatches = data.batches || [];
_adlRender();
_adlRenderBatchPanel();
_adlUpdateBadge();
// Don't call _adlUpdateBadge() here — it counts the truncated
// 300-item local array. The WebSocket status push already
// maintains the badge with the real server-side active count.
}
} catch (e) {
console.error('Downloads page fetch error:', e);