danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

no-sound fix: resume context on the 'play' event (covers all play paths)

Browse source 
Harden the previous fix: setPlayingState(true) misses resume/play calls that
bypass it (lines that just do 'if paused, play()'). Move the resume onto the
audio element's 'play' event, which fires on every playback start regardless
of code path. Keep the resume in npInitVisualizer for the first-play case
(context is created suspended after the 'play' event already fired). Drop the
now-redundant setPlayingState hook.
This commit is contained in:
BoulderBadgeDad 2026-06-04 14:36:06 -07:00
parent 5cb65ab00e
commit 3fe635fcd6
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
webui/static/media-player.js
View file

@ -23,6 +23,11 @@ function initializeMediaPlayer() {
audioPlayer.addEventListener('error', onAudioError);
audioPlayer.addEventListener('loadstart', onAudioLoadStart);
audioPlayer.addEventListener('canplay', onAudioCanPlay);
// Universal: once the visualizer routes this element through
// npAudioContext, the element is silent while that context is
// suspended. The 'play' event fires on EVERY playback start (every
// code path, incl. ones that bypass setPlayingState), so resume here.
audioPlayer.addEventListener('play', npEnsureAudioContextRunning);
// Set initial volume — restore the saved level (Spotify-style), else 70%.
const _savedVol = npLoadSavedVolume();
@ -304,10 +309,6 @@ function setPlayingState(playing) {
// Sidebar audio visualizer
if (playing) {
npInitVisualizer();
// npInitVisualizer only runs its setup once; the element stays routed
// through npAudioContext, so resume it on EVERY play start or playback
// is silent when the context has been suspended (autoplay / tab blur).
npEnsureAudioContextRunning();
startSidebarVisualizer();
} else {
stopSidebarVisualizer();