danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Artist Map v2 fix: streamed art now appears on its own (no manual zoom)

Browse source 
Root cause of the 'loads as placeholder orbs, only pops in after a zoom' bug:
streamed images were cached in _artMap.images but written into the buffer via
the per-node composite path, which didn't reliably refresh in one-island /
overflow mode — so covers stayed as placeholders until a zoom forced a full
rebuild that picked up the cached bitmaps.

Now that each map's buffer is small (one focused island, or a small explore
map), a throttled FULL rebuild on image arrival is cheap and always bakes every
cached image. Dropped the composite call from the stream; art fills in by itself
as it loads. 64 JS integrity tests pass.
This commit is contained in:
BoulderBadgeDad 2026-06-03 13:13:09 -07:00
parent f95b52e3c4
commit 37595314f1
1 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
webui/static/discover.js
View file

@ -7009,8 +7009,11 @@ function _artMapStreamImages(imgNodes, concurrent = 24) {
const queue = imgNodes.filter(n => n.image_url).slice().sort((a, b) => (b.radius || 0) - (a.radius || 0)); const queue = imgNodes.filter(n => n.image_url).slice().sort((a, b) => (b.radius || 0) - (a.radius || 0));
let idx = 0, inFlight = 0, redrawPending = false; let idx = 0, inFlight = 0, redrawPending = false;
// Fallback full-rebuild path, used only if the buffer isn't ready yet // Throttled FULL rebuild as images arrive. The per-map buffer is now small
// (e.g. images returned before the first paint built the offscreen buffer). // (one focused island / a small explore map), so a full rebuild is cheap and
// — unlike the per-node composite — is guaranteed to pick up every cached
// image. This is what makes streamed art appear on its own instead of only
// after a manual zoom forced a rebuild.
const scheduleRedraw = () => { const scheduleRedraw = () => {
if (redrawPending || token !== _artMap._loadToken) return; if (redrawPending || token !== _artMap._loadToken) return;
redrawPending = true; redrawPending = true;
@ -7019,7 +7022,8 @@ function _artMapStreamImages(imgNodes, concurrent = 24) {
if (token !== _artMap._loadToken) return; if (token !== _artMap._loadToken) return;
_artMap.dirty = true; _artMap.dirty = true;
_artMapRender(); _artMapRender();
}, 280); _artMapEnsureAmbient();
}, 200);
}; };
function pump() { function pump() {
@ -7034,13 +7038,11 @@ function _artMapStreamImages(imgNodes, concurrent = 24) {
_artMap.images[n.id] = bmp; _artMap.images[n.id] = bmp;
// Hidden bubbles (other islands in one-island mode): just // Hidden bubbles (other islands in one-island mode): just
// cache the image for when you navigate there — don't // cache the image for when you navigate there — don't
// redraw/rebuild for something off-screen. // redraw for something off-screen.
if ((n.opacity || 0) < 0.01) return; if ((n.opacity || 0) < 0.01) return;
// Composite just this node into the existing buffer (cheap) // Throttled full rebuild — reliably bakes newly-arrived art
// and blit. Only fall back to a full rebuild if the buffer // into the (small) buffer. No manual zoom needed.
// isn't built yet. Keeps pan/hover at blit-speed while images stream. scheduleRedraw();
if (_artMapCompositeNode(n)) _artMapRender();
else scheduleRedraw();
} }
}) })
.finally(() => { inFlight--; pump(); }); .finally(() => { inFlight--; pump(); });