danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Merge pull request #414 from Nezreka/fix/hls-test-windows-extension

Browse source 
fix: pick OS-specific ffmpeg binary in hls demux fallback test
This commit is contained in:
BoulderBadgeDad 2026-04-28 21:17:19 -07:00 committed by GitHub
commit 278f30e336
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
tests/test_hls_parsing.py
View file

@ -7,6 +7,7 @@ The parsing logic is identical in ``tidal_download_client.py``; these tests
cover the shared behavior via ``hifi_client.HiFiClient``. cover the shared behavior via ``hifi_client.HiFiClient``.
""" """
import os
import shutil import shutil
import subprocess import subprocess
import sys import sys
@ -356,12 +357,15 @@ def test_demux_flac_uses_tools_dir_fallback(client, tmp_path, monkeypatch):
out = tmp_path / "output.flac" out = tmp_path / "output.flac"
tools_dir = Path(__file__).parent.parent / "tools" tools_dir = Path(__file__).parent.parent / "tools"
# _demux_flac picks the OS-specific binary name (ffmpeg.exe on Windows).
candidate_name = "ffmpeg.exe" if os.name == "nt" else "ffmpeg"
expected_candidate = tools_dir / candidate_name
original_exists = Path.exists original_exists = Path.exists
original_which = shutil.which original_which = shutil.which
def fake_exists(self): def fake_exists(self):
if str(self) == str(tools_dir / "ffmpeg"): if str(self) == str(expected_candidate):
return True return True
return original_exists(self) return original_exists(self)
@ -381,4 +385,4 @@ def test_demux_flac_uses_tools_dir_fallback(client, tmp_path, monkeypatch):
client._demux_flac(inp, out) client._demux_flac(inp, out)
call_args = mock_run.call_args[0][0] call_args = mock_run.call_args[0][0]
assert call_args[0] == str(tools_dir / "ffmpeg") assert call_args[0] == str(expected_candidate)