danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Don't highlight sidebar Library when on /artist-detail

Browse source 
Cin: arriving at artist-detail from Search/Discover/Watchlist
highlighted the Library sidebar entry, which is misleading — the user
didn't navigate via Library. The hardcoded mapping was a holdover from
when artist-detail was reached only from the (now retired) Artists page.

Drop the special case so artist-detail behaves like playlist-explorer:
no [data-page] match in the sidebar, no highlight. The user's actual
origin page is already preserved on the back button.

The deep-link fallback in _getPageFromPath (artist-detail → library)
is left intact: if someone pastes /artist-detail in the URL bar with
no state to render, library is still the most sensible landing page,
and sidebar-highlighting Library in that scenario is correct because
they're literally on Library.
This commit is contained in:
Broque Thomas 2026-04-22 22:25:06 -07:00
parent 02f26bf338
commit 1aedc2ddcf
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
webui/static/init.js
View file

@ -2131,14 +2131,14 @@ function navigateToPage(pageId, options = {}) {
return; return;
} }
// Update navigation buttons (only if there's a nav button for this page) // Update navigation buttons (only if there's a nav button for this page).
// Pages reachable from many surfaces (artist-detail, playlist-explorer)
// intentionally have no [data-page] match here — the sidebar shouldn't
// imply a section the user didn't actually navigate via.
document.querySelectorAll('.nav-button').forEach(btn => { document.querySelectorAll('.nav-button').forEach(btn => {
btn.classList.remove('active'); btn.classList.remove('active');
}); });
const navButton = document.querySelector(`[data-page="${pageId}"]`);
// Handle artist-detail page specially - it should highlight the 'library' nav button
const navPageId = pageId === 'artist-detail' ? 'library' : pageId;
const navButton = document.querySelector(`[data-page="${navPageId}"]`);
if (navButton) { if (navButton) {
navButton.classList.add('active'); navButton.classList.add('active');
} }