danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

#916: enhanced view stops flagging multi-disc tracks as missing

Browse source 
Multi-disc albums store disc_number=1 for EVERY track in the library (verified across the live
DB — even a 175-track OST shows disc[1..1]; the scanner doesn't split discs). The enhanced view
matched owned<->canonical tracks strictly by disc:track_number slot, so every canonical disc-2+
track (slot 2:N) found no owned counterpart and was flagged missing ('62/72 · 36 missing').

_deriveEnhancedMissingTracks now matches each canonical track by slot first, then falls back to
title against any UNUSED owned track (consuming each owned track once, so genuine missings and
duplicate titles still count right). Display-only — no scanner/data change.

Verified by simulation (62 owned all disc-1, 72 canonical across 2 discs): old logic flags 36
missing, new flags 10 (the genuinely-absent tracks). Frontend-only; repo has no JS test runner.
This commit is contained in:
BoulderBadgeDad 2026-06-23 15:32:26 -07:00
parent 15fa64248c
commit 16cb29c9ee
1 changed files with 42 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

53
webui/static/library.js
View file

@ -3964,23 +3964,54 @@ async function ensureEnhancedAlbumCanonicalTracks(album) {
}
}
// Loose title key for owned<->canonical matching. Lowercase, drop bracketed
// annotations ((feat. X), [Explicit]) and punctuation so editions line up.
function _normTitleForMatch(value) {
return String(value || '')
.toLowerCase()
.replace(/\([^)]*\)|\[[^\]]*\]/g, ' ')
.replace(/[^a-z0-9]+/g, ' ')
.trim();
}
function _deriveEnhancedMissingTracks(album, canonicalTracks) {
const occupiedSlots = new Set();
(album.tracks || []).forEach(track => {
// #916: multi-disc albums store disc_number = 1 for EVERY track in the library
// (the scanner doesn't split discs), so a strict disc:track slot match flags every
// canonical disc-2+ track as missing. Match each canonical track to an owned track
// by slot FIRST, then fall back to title — consuming each owned track once so genuine
// missings and duplicate titles still count correctly.
const owned = (album.tracks || []).map(t => ({
slot: _trackSlotKey(t),
title: _normTitleForMatch(t.title || t.name),
used: false,
}));
const slotIndex = new Map();
owned.forEach((o, i) => { if (o.slot !== '1:0' && !slotIndex.has(o.slot)) slotIndex.set(o.slot, i); });
const missing = [];
(canonicalTracks || []).forEach(track => {
const key = _trackSlotKey(track);
if (key !== '1:0') occupiedSlots.add(key);
});
return (canonicalTracks || [])
.map(track => ({
const normalized = _normalizeExpectedMissingTrack(track, album);
if (key === '1:0' || !normalized._hasActionableContext) return;
// 1) exact disc:track slot
const si = slotIndex.get(key);
if (si != null && !owned[si].used) { owned[si].used = true; return; }
// 2) fallback: title vs any UNUSED owned track (handles the disc_number=1 collapse)
const nt = _normTitleForMatch(track.name || track.title);
if (nt) {
const m = owned.find(o => !o.used && o.title === nt);
if (m) { m.used = true; return; }
}
missing.push({
...track,
name: track.name || track.title,
duration_ms: track.duration_ms || track.duration || 0,
}))
.filter(track => {
const key = _trackSlotKey(track);
const normalized = _normalizeExpectedMissingTrack(track, album);
return key !== '1:0' && normalized._hasActionableContext && !occupiedSlots.has(key);
});
});
return missing;
}
function _getEnhancedAlbumTrackRows(album) {