From 81da2ac193e5bc1ecd7eefcfb3da219f91c151e7 Mon Sep 17 00:00:00 2001
From: ibizaman <ibizaman@tiserbox.com>
Date: Mon, 8 Dec 2025 11:08:46 +0100
Subject: [PATCH] ssl: add assertion to catch duplicate domain names

---
 modules/blocks/ssl.nix | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/modules/blocks/ssl.nix b/modules/blocks/ssl.nix
index 7be26a1..5321d3d 100644
--- a/modules/blocks/ssl.nix
+++ b/modules/blocks/ssl.nix
@@ -338,6 +338,40 @@ in
       serviceName = lib.strings.removeSuffix ".service";
     in
     lib.mkMerge [
+      # Generic assertions
+      {
+        assertions = lib.flatten (
+          lib.mapAttrsToList (
+            _name: certCfg:
+            (
+              let
+                domainInExtraDomains =
+                  (lib.lists.findFirstIndex (x: x == certCfg.domain) null certCfg.extraDomains) != null;
+                firstDuplicateDomain =
+                  (
+                    l:
+                    let
+                      sorted = lib.sort (x: y: x < y) l;
+                      maybeDupe = lib.lists.removePrefix (lib.lists.commonPrefix (lib.uniqueStrings sorted) sorted) sorted;
+                    in
+                    if maybeDupe == [ ] then null else lib.head maybeDupe
+                  )
+                    certCfg.extraDomains;
+              in
+              [
+                {
+                  assertion = !domainInExtraDomains;
+                  message = "Error in SHB option for domain ${certCfg.domain}: do not repeat the domain name in the `extraDomain` option.";
+                }
+                {
+                  assertion = firstDuplicateDomain == null;
+                  message = "Error in SHB option for domain ${certCfg.domain}: `extraDomain` option cannot have duplicates, first offender is: ${firstDuplicateDomain} in the following list: ${lib.concatStringsSep " " certCfg.extraDomains}.";
+                }
+              ]
+            )
+          ) (cfg.certs.selfsigned // cfg.certs.letsencrypt)
+        );
+      }
       # Config for self-signed CA.
       {
         systemd.services = lib.mapAttrs' (