UnpackClient now sanitizes the torrent directory name when building
extractPath, so the post-unpack TorBox move needs to compare against
the sanitized name as well. Without this, extractPath.EndsWith(rdName)
takes the wrong branch for any torrent whose RdName contained brackets
and files end up in the hash subdirectory instead of the torrent
directory.
Reported by @omgbeez.
- Applied to TorBox, can be extended easily to other providers
- Reads response headers commonplace for pre-emptive rate limit throttling and retry-after
- When a rate limit is reached, displays a warning in the UI
- Fix socket leak from direct allocation of HttpClient, replaced with factory which handles pooling and re-use of sockets.
While HttpClient is Disposable, it doesn't gaurantee (and does not) directly release underlying sockets for queries at the time the client is disposed. These sockets will go into a TCP WAIT state often for a very long time. The expected pattern in C# is to always use the HttClientFactory which will correctly handle re-use of the OS sockets in suqsequent queries reducing resource and memory leaks.
