danvics/rdt-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Simplify comments

Browse source
This commit is contained in:
Antonin Lenfant-Kodia 2026-06-15 15:58:23 +02:00
parent 643a2e3d63
commit b2a725c285
3 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
server/RdtClient.Data/Models/Internal/DbSettings.cs
View file

@ -154,7 +154,7 @@ http://127.0.0.1:6800/jsonrpc.")]
public String DownloadStationUrl { get; set; } = "http://127.0.0.1:5000";
[DisplayName("Synology DownloadStation Username")]
[Description("The username to use when connecting to the Synology DownloadStation.")]
[Description("The username to use when connecting to the Synology DownloadStation. The account needs Download Station and File Station permissions (so the per-download destination folder can be created).")]
public String? DownloadStationUsername { get; set; } = null;
[DisplayName("Synology DownloadStation Password")]
@ -162,7 +162,7 @@ http://127.0.0.1:6800/jsonrpc.")]
public String? DownloadStationPassword { get; set; } = null;
[DisplayName("Synology Download Station Download Path")]
[Description("The root path on the Synology to download to, relative to a shared folder (e.g. \"Media/Downloads/Torrents\"), NOT an absolute path like \"/volume1/Media/...\". If empty, the default Download Station destination is used. The account also needs File Station permission so the per-download destination folder can be created.")]
[Description("The root path to download the file on the Synology DownloadStation host, if empty the default DownloadStation path is used.")]
public String? DownloadStationDownloadPath { get; set; } = null;
[DisplayName("Minimum free disk space (GB) (Bezzad only)")]

2
server/RdtClient.Service.Test/Services/Downloaders/DownloadStationDownloaderTest.cs
View file

@ -88,7 +88,7 @@ public class DownloadStationDownloaderTest
// Assert: an existing task must be reused (idempotent), not re-created or thrown as "already added".
// Throwing would brick every retry that reuses the gid because the DownloadStation delete fails to
// deserialize its response (upstream #792), so the task is never actually removed.
// deserialize its response, so the task is never actually removed.
Assert.Equal(mocks.Gid, gid);
mocks.TaskEndpointMock.Verify(t => t.GetInfoAsync(mocks.Gid), Times.Once);
mocks.TaskEndpointMock.VerifyNoOtherCalls();

8
server/RdtClient.Service/Services/Downloaders/DownloadStationDownloader.cs
View file

@ -116,7 +116,7 @@ public class DownloadStationDownloader : IDownloader
}
catch (Exception ex)
{
// The Synology DELETE response can itself fail to deserialize (upstream #792); don't let cleanup throw.
// The Synology DELETE response can itself fail to deserialize; don't let cleanup throw.
_logger.Debug($"Failed to remove DownloadStation task {_gid}: {ex.Message}");
}
}
@ -140,8 +140,8 @@ public class DownloadStationDownloader : IDownloader
{
// A task for this download already exists in DownloadStation; adopt it instead of throwing.
// Throwing here permanently bricks every retry that reuses the gid: the caller Cancel()s first,
// but the DownloadStation delete response fails to deserialize (upstream #792) so the task is not
// actually removed, and the next Download() then errors with "already added" forever.
// but the DownloadStation delete response fails to deserialize so the task is not actually
// removed, and the next Download() then errors with "already added" forever.
_logger.Debug($"Download with ID {_gid} already exists in DownloadStation; reusing it");
return _gid;
@ -389,7 +389,7 @@ public class DownloadStationDownloader : IDownloader
}
catch (Exception ex)
{
// The task-list response can fail to deserialize when a task carries a non-string error_detail (upstream #723);
// The task-list response can fail to deserialize when a task carries a non-string error_detail;
// treat that as "not found" instead of aborting the whole download.
_logger.Debug($"Failed to list DownloadStation tasks for {_uri}: {ex.Message}");