danvics/rdt-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: make SymlinkDownloader single-shot with existing-link guard

Browse source
This commit is contained in:
mainLink0435 2026-06-05 20:03:46 +10:00
parent 38530cd6fd
commit 88dcb9aa60
1 changed files with 26 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

60
server/RdtClient.Service/Services/Downloaders/SymlinkDownloader.cs
View file

@ -1,4 +1,4 @@
using RdtClient.Data.Enums; using RdtClient.Data.Enums;
using RdtClient.Service.Helpers; using RdtClient.Service.Helpers;
using Serilog; using Serilog;
@ -6,8 +6,6 @@ namespace RdtClient.Service.Services.Downloaders;
public class SymlinkDownloader(String uri, String destinationPath, String path, Provider? clientKind) : IDownloader public class SymlinkDownloader(String uri, String destinationPath, String path, Provider? clientKind) : IDownloader
{ {
private const Int32 MaxRetries = 10;
private readonly CancellationTokenSource _cancellationToken = new(); private readonly CancellationTokenSource _cancellationToken = new();
private readonly ILogger _logger = Log.ForContext<SymlinkDownloader>(); private readonly ILogger _logger = Log.ForContext<SymlinkDownloader>();
@ -108,44 +106,32 @@ public class SymlinkDownloader(String uri, String destinationPath, String path,
potentialFilePaths = potentialFilePaths.Distinct().ToList(); potentialFilePaths = potentialFilePaths.Distinct().ToList();
for (var retryCount = 0; retryCount < MaxRetries; retryCount++) _logger.Debug($"Searching {rcloneMountPath} for {fileName}...");
file = FindFile(rcloneMountPath, potentialFilePaths, fileName);
if (file == null && searchSubDirectories)
{ {
DownloadProgress?.Invoke(this, var subDirectories = Directory.GetDirectories(rcloneMountPath, "*.*", SearchOption.TopDirectoryOnly);
new()
{
BytesDone = retryCount,
BytesTotal = 10,
Speed = 1
});
_logger.Debug($"Searching {rcloneMountPath} for {fileName} (attempt #{retryCount})..."); foreach (var subDirectory in subDirectories)
file = FindFile(rcloneMountPath, potentialFilePaths, fileName);
if (file == null && searchSubDirectories)
{ {
var subDirectories = Directory.GetDirectories(rcloneMountPath, "*.*", SearchOption.TopDirectoryOnly); file = FindFile(Path.Combine(rcloneMountPath, subDirectory), potentialFilePaths, fileName);
foreach (var subDirectory in subDirectories) if (file != null)
{ {
file = FindFile(Path.Combine(rcloneMountPath, subDirectory), potentialFilePaths, fileName); break;
if (file != null)
{
break;
}
} }
} }
if (file == null)
{
await Task.Delay(1000 * retryCount);
}
else
{
break;
}
} }
DownloadProgress?.Invoke(this,
new()
{
BytesDone = 1,
BytesTotal = 1,
Speed = 0
});
} }
if (file == null) if (file == null)
@ -172,7 +158,7 @@ public class SymlinkDownloader(String uri, String destinationPath, String path,
if (!result) if (!result)
{ {
throw new("Could not find file from rclone mount!"); throw new("Could not create symbolic link!");
} }
DownloadComplete?.Invoke(this, new()); DownloadComplete?.Invoke(this, new());
@ -229,6 +215,12 @@ public class SymlinkDownloader(String uri, String destinationPath, String path,
{ {
try try
{ {
if (File.Exists(symlinkPath)) // Symlink already exists from a prior run.
{
_logger.Information($"Symbolic link already exists at {symlinkPath}");
return true;
}
File.CreateSymbolicLink(symlinkPath, sourcePath); File.CreateSymbolicLink(symlinkPath, sourcePath);
if (File.Exists(symlinkPath)) // Double-check that the link was created if (File.Exists(symlinkPath)) // Double-check that the link was created