From 794eec8666ed70eb2753ff3370d4ba3d31e5bde4 Mon Sep 17 00:00:00 2001 From: Roger Far Date: Fri, 7 Mar 2025 12:29:33 -0700 Subject: [PATCH] Fixed vulnerability issue where the auth Update endpoint wasn't protected. --- server/RdtClient.Web/Controllers/AuthController.cs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/server/RdtClient.Web/Controllers/AuthController.cs b/server/RdtClient.Web/Controllers/AuthController.cs index 5b10017..9a3f6ee 100644 --- a/server/RdtClient.Web/Controllers/AuthController.cs +++ b/server/RdtClient.Web/Controllers/AuthController.cs @@ -82,6 +82,13 @@ public class AuthController(Authentication authentication, Settings settings) : return StatusCode(401); } + var user = await authentication.GetUser(); + + if (user != null) + { + return StatusCode(401); + } + await settings.Update("Provider:Provider", request.Provider); await settings.Update("Provider:ApiKey", request.Token); @@ -130,6 +137,7 @@ public class AuthController(Authentication authentication, Settings settings) : [Route("Update")] [HttpPost] + [Authorize(Policy = "AuthSetting")] public async Task Update([FromBody] AuthControllerUpdateRequest? request) { if (request == null)